Opened 5 years ago

Last modified 4 years ago

#4087 task new

twisted.manhole.telnet is using the deprecated twisted.protocols.telnet

Reported by: MizardX Owned by:
Priority: normal Milestone:
Component: core Keywords: manhole, telnet
Cc: khorn Branch:
Author: Launchpad Bug:

Description

The module twisted.manhole.telnet is still using the deprecated module twisted.protocols.telnet. It should be updated to use the new twisted.manhole.* modules, or be deprecated itself.

Change History (6)

comment:1 Changed 5 years ago by khorn

I'm guessing this

It should be updated to use the new twisted.manhole.* modules, or be deprecated itself. 

should read:

It should be updated to use the new twisted.conch.telnet module, or be deprecated itself. 

???

I don't see any telnet stuff in twisted.manhole.* ...

comment:2 Changed 5 years ago by khorn

  • Cc khorn added

comment:3 Changed 5 years ago by exarkun

Yes

comment:4 follow-up: Changed 5 years ago by exarkun

I suggest deprecation. The functionality provided by twisted.manhole.telnet is a proper subset of the functionality provided by Twisted Conch's newer manhole code.

It's tempting to suggest the deprecation of all of twisted.manhole. The functionality provided is nice, but the implementation is variously poorly tested, outright broken, and exposes irrelevant implementation details.

twisted.conch.manhole.ManholeInterpreter is probably a better implementation of the core functionality (ie, evaluating incrementally supplied lines of Python source). The Gtk manhole GUI, gladereactor, explorer, and inspectro are the more interesting pieces (except they don't work so well). It'd be nice if they were implemented in a way which allowed them to be re-used to re-expose the functionality over new protoocols - then Conch could include telnet/ssh interfaces.

Anyway, I don't know how coherent all of that is. The take-home message is that twisted.manhole.telnet should be deprecated, though.

comment:5 in reply to: ↑ 4 Changed 4 years ago by glyph

Replying to exarkun:

It's tempting to suggest the deprecation of all of twisted.manhole. The functionality provided is nice, but the implementation is variously poorly tested, outright broken, and exposes irrelevant implementation details.

I was thusly tempted. See #4808.

comment:6 Changed 3 years ago by <automation>

  • Owner glyph deleted
Note: See TracTickets for help on using tickets.