twisted.manhole.telnet is using the deprecated twisted.protocols.telnet

[MizardX]

The module twisted.manhole.telnet is still using the deprecated module twisted.protocols.telnet. It should be updated to use the new twisted.manhole.* modules, or be deprecated itself.

[khorn]

I'm guessing this

It should be updated to use the new twisted.manhole.* modules, or be deprecated itself. 

should read:

It should be updated to use the new twisted.conch.telnet module, or be deprecated itself. 

???

I don't see any telnet stuff in twisted.manhole.* ...

[exarkun]

Yes

[exarkun]

I suggest deprecation. The functionality provided by twisted.manhole.telnet is a proper subset of the functionality provided by Twisted Conch's newer manhole code.

It's tempting to suggest the deprecation of all of twisted.manhole. The functionality provided is nice, but the implementation is variously poorly tested, outright broken, and exposes irrelevant implementation details.

twisted.conch.manhole.ManholeInterpreter is probably a better implementation of the core functionality (ie, evaluating incrementally supplied lines of Python source). The Gtk manhole GUI, gladereactor, explorer, and inspectro are the more interesting pieces (except they don't work so well). It'd be nice if they were implemented in a way which allowed them to be re-used to re-expose the functionality over new protoocols - then Conch could include telnet/ssh interfaces.

Anyway, I don't know how coherent all of that is. The take-home message is that twisted.manhole.telnet should be deprecated, though.

[glyph]

Replying to exarkun:

It's tempting to suggest the deprecation of all of twisted.manhole. The functionality provided is nice, but the implementation is variously poorly tested, outright broken, and exposes irrelevant implementation details.

I was thusly tempted. See #4808.