Ticket #4084 enhancement closed fixed

Opened 4 years ago

Last modified 17 months ago

Delete obsolete zsh_* code in tap2rpm

Reported by: TimAllen Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

twisted.scripts.tap2rpm.MyOptions has a bunch of class variables named zsh_*, mostly commented out. If they work and are useful to somebody, they should be uncommented; if they don't work they should be fixed or (more likely) deleted. t.p.usage doesn't mention zsh anywhere, so I assume these zsh properties are just dead code left over from someone's attempt at integrating with zsh's tab-completion.

Change History

1

Changed 4 years ago by TimAllen

This ticket split off from #3292.

2

Changed 4 years ago by rvoicilas

Is this still valid ... as far as I can see it seems that most of the scripts don't make use of zsh_* class variables? Is it ok if I delete them or they are still used as options for the code from twisted/python/zsh ?

3

Changed 4 years ago by glyph

  • owner changed from glyph to TimAllen

4

Changed 4 years ago by teratorn

  • owner changed from TimAllen to teratorn
  • status changed from new to assigned

The zsh_* attributes are there so that folks maintaining Options classes know what they have to work with in terms of specifying metadata to the zsh tab-completion code....

Since their presence has confused at least 1 person I will go through and add notes in all places where these attributes occur pointing people to the documentation for them.

Work on cleaning up the zsh completion code is currently in progress. See #3078

I'll include said notes in that branch, and close this ticket when it is merged.

5

Changed 3 years ago by binjured

  • keywords easy removed

Removed "easy" as there doesn't appear to be anything to do here but wait for the other issue to close.

6

Changed 3 years ago by <automation>

  • owner teratorn deleted

7

Changed 17 months ago by teratorn

  • status changed from assigned to closed
  • resolution set to fixed

This issue no longer exists as #3078 has been merged.

Note: See TracTickets for help on using tickets.