Opened 5 years ago

Closed 5 years ago

#4083 enhancement closed fixed (fixed)

tap2rpm's default long description should mention tap2rpm, not tap2deb

Reported by: TimAllen Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: thijs Branch:
Author: Launchpad Bug:

Description

Currently, twisted.scripts.tap2rpm contains the following line of code:

long_description = (config['long_description']
		    or 'Automatically created by tap2deb')

It should of course say "Automatically created by tap2rpm".

Attachments (2)

4083.patch (2.6 KB) - added by Poincare 5 years ago.
reivew
4083.2.patch (2.6 KB) - added by Poincare 5 years ago.
Please reivew

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by TimAllen

This ticket split off from #3292.

Changed 5 years ago by Poincare

reivew

Changed 5 years ago by Poincare

Please reivew

comment:2 Changed 5 years ago by jonathanj

  • Keywords review added
  • Owner glyph deleted

comment:3 Changed 5 years ago by jonathanj

  • Keywords review removed
  • Owner set to Poincare

Perhaps I'm confused, but this ticket talks about tap2rpm's description while the patch also deletes aimbot.py. What's up with that?

comment:4 Changed 5 years ago by thijs

  • Cc thijs added

comment:5 Changed 5 years ago by thijs

  • Owner changed from Poincare to thijs
  • Status changed from new to assigned

I'll create a new patch and apply it.

comment:6 Changed 5 years ago by thijs

New patch:

  • twisted/scripts/tap2rpm.py

     
    225225    description = config['description'] or ('A TCP server for %(protocol)s' % 
    226226                                            vars()) 
    227227    long_description = (config['long_description'] 
    228                         or 'Automatically created by tap2deb') 
     228                        or "Automatically created by tap2rpm") 
    229229    twistd_option = type_dict[config['type']] 
    230230    date = time.strftime('%a %b %d %Y', time.localtime(time.time())) 
    231231    directory = rpm_file + '-' + version 

comment:7 Changed 5 years ago by thijs

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [27636]) Fix the default long description of tap2rpm, that incorrectly
was talking about tap2deb.

Author: Poincare
Reviewer: jonathanj, thijs
Fixes: #4083

comment:8 Changed 4 years ago by <automation>

  • Owner thijs deleted
Note: See TracTickets for help on using tickets.