Opened 8 years ago

Closed 8 years ago

#4063 defect closed fixed (fixed)

Ween trial's --dry-run away from the deprecated TestCase.visitor code.

Reported by: kelly Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Thijs Triemstra Branch: branches/dry-run-4063
branch-diff, diff-cov, branch-cov, buildbot
Author: kelly, thijs

Description

t.t.runner.TrialRunner is still using the deprecated visitor code to do --dry-run.

Attachments (1)

fix-dry-run.patch (2.5 KB) - added by kelly 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by kelly

Attachment: fix-dry-run.patch added

comment:1 Changed 8 years ago by Thijs Triemstra

Author: thijs
Branch: branches/dry-run-4063

(In [27434]) Branching to 'dry-run-4063'

comment:2 Changed 8 years ago by Thijs Triemstra

Author: thijskelly, thijs
Cc: Thijs Triemstra added

Thanks kelly, I branched in r27435

comment:3 Changed 8 years ago by Thijs Triemstra

(In [27437]) Add copyright header, refs #4063

comment:4 Changed 8 years ago by Jonathan Lange

Keywords: review removed
Owner: changed from Jonathan Lange to Thijs Triemstra

There's already a method that does this called _iterateTests, which lives in twisted.trial.util. Can you please simply change dry-run to use that?

comment:5 Changed 8 years ago by Jean-Paul Calderone

Owner: changed from Thijs Triemstra to Jean-Paul Calderone
Status: newassigned

comment:6 Changed 8 years ago by Jean-Paul Calderone

(In [27506]) Remove _depthFirst and use _iterateTests

Refs #4063

comment:7 Changed 8 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Jonathan Lange
Status: assignednew

comment:8 Changed 8 years ago by Jonathan Lange

Keywords: review removed
Owner: changed from Jonathan Lange to Jean-Paul Calderone

Thanks Jean-Paul! Please land this with my blessing.

Thanks to kelly & thijs too.

comment:9 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [27510]) Merge dry-run-4063

Author: kelly, thijs, exarkun Reviewer: jml Fixes: #4063

Stop using the deprecated DryRunVisitor to implement the trial --dry-run feature. Instead, use a private trial helper to iterate over all of the test cases and start/succeed/stop them.

comment:10 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.