Opened 5 years ago

Closed 4 years ago

#4007 defect closed fixed (fixed)

Remove doc/words/examples/aimbot.py

Reported by: ivank Owned by:
Priority: low Milestone:
Component: words Keywords: documentation
Cc: thijs, exarkun, njoyce, djfroofy Branch: branches/remove-aimbot-4007
(diff, github, buildbot, log)
Author: djroofy, thijs Launchpad Bug:

Description (last modified by thijs)

aimbot.py doesn't work. If you run it with logging, you'll see something like this:

2009-09-06 12:23:56-0700 [-] Log opened.
2009-09-06 12:23:56-0700 [-] aimbot.py:14: exceptions.DeprecationWarning: twisted.words.protocols.toc is deprecated since Twisted 9.0.  Use twisted.words.protocols.oscar instead.
2009-09-06 12:23:57-0700 [-] /opt/Python-latest/lib/python2.7/site-packages/twisted/words/im/__init__.py:8: exceptions.UserWarning: twisted.im will be undergoing a rewrite at some point in the future.
2009-09-06 12:23:57-0700 [Uninitialized] connection made! <<class 'twisted.internet.tcp.Client'> to ('toc.oscar.aol.com', 9898) at 16717d0>
2009-09-06 12:23:57-0700 [aimBot,client] 
                                           MYUSERNAME
2009-09-06 12:23:57-0700 [aimBot,client] toc_signon login.oscar.aol.com 5190  MYUSERNAME 0x161e0b4d20169760 english "penguin"

The account never appears online.

twisted.words.protocols.toc was deprecated in #3580.

Attachments (2)

mypatch.patch (1.9 KB) - added by Poincare 5 years ago.
review
removeaimbot-4007.diff (2.6 KB) - added by djfroofy 4 years ago.
Remove aimbot.py example and ref in docs

Download all attachments as: .zip

Change History (23)

comment:1 Changed 5 years ago by thijs

  • Cc thijs added

What about rewriting it with twisted.words.protocols.oscar instead?

comment:2 Changed 5 years ago by ivank

  • Keywords documentation easy review added

oscardemo.py already does that, I think.

comment:3 Changed 5 years ago by ivank

  • Owner exarkun deleted

comment:4 Changed 5 years ago by exarkun

  • Cc exarkun added
  • Keywords review removed
  • Owner set to ivank

I think this is premature. twisted.words.protocols.toc hasn't been deprecated in any release yet. It's probably useless, but the example should stay until the code itself is removed. That would be in 9.0+2.

Changed 5 years ago by Poincare

review

comment:5 Changed 5 years ago by njoyce

  • Cc njoyce added
  • Keywords review added

Now that #3580 is fixed and twisted.words.protocols.toc is deprecated, the attached patch appears to do the job.

comment:6 Changed 5 years ago by njoyce

  • Owner ivank deleted

comment:7 Changed 4 years ago by djfroofy

  • Owner set to djfroofy
  • Status changed from new to assigned

Changed 4 years ago by djfroofy

Remove aimbot.py example and ref in docs

comment:8 Changed 4 years ago by djfroofy

  • Cc djfroofy added
  • Owner changed from djfroofy to exarkun
  • Status changed from assigned to new

Updated a patch with reference removed in documentation. If twisted.words.protocols.toc was supposed to removed in 9.0+2 maybe it's due time to really remove it considering current 10.0 release?

comment:9 Changed 4 years ago by djfroofy

  • Priority changed from normal to highest

comment:10 Changed 4 years ago by exarkun

  • Keywords review removed
  • Priority changed from highest to low

We need to wait a bit longer on this. 9.0 was released in December, three months ago. We can think about this for the release around December 2010.

comment:11 Changed 4 years ago by amacleod

  • Keywords easy removed

This ticket depends on #4363 (remove TOC)

comment:12 Changed 4 years ago by thijs

  • Author set to thijs
  • Branch set to branches/remove-aimbot-4007

(In [30527]) Branching to 'remove-aimbot-4007'

comment:13 Changed 4 years ago by thijs

(In [30528]) Apply removeaimbot-4007.diff. refs #4007

comment:14 Changed 4 years ago by thijs

(In [30529]) add news file. refs #4007

comment:15 Changed 4 years ago by thijs

  • Author changed from thijs to djroofy, thijs
  • Description modified (diff)
  • Keywords review added
  • Owner exarkun deleted

comment:16 follow-up: Changed 4 years ago by cyli

  • Keywords review removed
  • Owner set to thijs

This only seems to remove the content of the aimbot.py file. Could you remove the file itself?

Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

comment:17 Changed 4 years ago by thijs

  • Status changed from new to assigned

Thanks for the review.

comment:18 Changed 4 years ago by thijs

(In [30538]) Actually remove file, refs #4007

comment:19 in reply to: ↑ 16 Changed 4 years ago by thijs

Replying to cyli:

This only seems to remove the content of the aimbot.py file. Could you remove the file itself?

Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

Results for the documentation builder. I'll merge it after #4363 landed.

comment:20 Changed 4 years ago by thijs

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [30544]) Merge remove-aimbot-4007: Removed the non-working AIM bot example, depending on the obsolete
twisted.words.protocols.toc functionality.

Author: thijs, djroofy
Reviewer: cyli
Fixes: #4007

comment:21 Changed 4 years ago by <automation>

  • Owner thijs deleted
Note: See TracTickets for help on using tickets.