Remove doc/words/examples/aimbot.py

[ivank]

aimbot.py doesn't work. If you run it with logging, you'll see something like this:

2009-09-06 12:23:56-0700 [-] Log opened.
2009-09-06 12:23:56-0700 [-] aimbot.py:14: exceptions.DeprecationWarning: twisted.words.protocols.toc is deprecated since Twisted 9.0.  Use twisted.words.protocols.oscar instead.
2009-09-06 12:23:57-0700 [-] /opt/Python-latest/lib/python2.7/site-packages/twisted/words/im/__init__.py:8: exceptions.UserWarning: twisted.im will be undergoing a rewrite at some point in the future.
2009-09-06 12:23:57-0700 [Uninitialized] connection made! <<class 'twisted.internet.tcp.Client'> to ('toc.oscar.aol.com', 9898) at 16717d0>
2009-09-06 12:23:57-0700 [aimBot,client] 
                                           MYUSERNAME
2009-09-06 12:23:57-0700 [aimBot,client] toc_signon login.oscar.aol.com 5190  MYUSERNAME 0x161e0b4d20169760 english "penguin"

The account never appears online.

twisted.words.protocols.toc was deprecated in #3580.

[thijs]

What about rewriting it with twisted.words.protocols.oscar instead?

[ivank]

oscardemo.py already does that, I think.

[exarkun]

I think this is premature. twisted.words.protocols.toc hasn't been deprecated in any release yet. It's probably useless, but the example should stay until the code itself is removed. That would be in 9.0+2.

[Poincare]

review

[njoyce]

Now that #3580 is fixed and twisted.words.protocols.toc is deprecated, the attached patch appears to do the job.

[djfroofy]

Remove aimbot.py example and ref in docs

[djfroofy]

Updated a patch with reference removed in documentation. If twisted.words.protocols.toc was supposed to removed in 9.0+2 maybe it's due time to really remove it considering current 10.0 release?

[exarkun]

We need to wait a bit longer on this. 9.0 was released in December, three months ago. We can think about this for the release around December 2010.

[amacleod]

This ticket depends on #4363 (remove TOC)

[thijs]

(In [30527]) Branching to 'remove-aimbot-4007'

[thijs]

(In [30528]) Apply removeaimbot-4007.diff. refs #4007

[thijs]

(In [30529]) add news file. refs #4007

[cyli]

This only seems to remove the content of the aimbot.py file. Could you remove the file itself?

Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

[thijs]

Thanks for the review.

[thijs]

(In [30538]) Actually remove file, refs #4007

[thijs]

Replying to cyli:

This only seems to remove the content of the aimbot.py file. Could you remove the file itself? Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

Results for the  documentation builder. I'll merge it after #4363 landed.

[thijs]

(In [30544]) Merge remove-aimbot-4007: Removed the non-working AIM bot example, depending on the obsolete twisted.words.protocols.toc functionality.

Author: thijs, djroofy Reviewer: cyli Fixes: #4007