Opened 8 years ago

Closed 6 years ago

#4007 defect closed fixed (fixed)

Remove doc/words/examples/aimbot.py

Reported by: ivank Owned by:
Priority: low Milestone:
Component: words Keywords: documentation
Cc: Thijs Triemstra, Jean-Paul Calderone, njoyce, Drew Smathers Branch: branches/remove-aimbot-4007
branch-diff, diff-cov, branch-cov, buildbot
Author: djroofy, thijs

Description (last modified by Thijs Triemstra)

aimbot.py doesn't work. If you run it with logging, you'll see something like this:

2009-09-06 12:23:56-0700 [-] Log opened.
2009-09-06 12:23:56-0700 [-] aimbot.py:14: exceptions.DeprecationWarning: twisted.words.protocols.toc is deprecated since Twisted 9.0.  Use twisted.words.protocols.oscar instead.
2009-09-06 12:23:57-0700 [-] /opt/Python-latest/lib/python2.7/site-packages/twisted/words/im/__init__.py:8: exceptions.UserWarning: twisted.im will be undergoing a rewrite at some point in the future.
2009-09-06 12:23:57-0700 [Uninitialized] connection made! <<class 'twisted.internet.tcp.Client'> to ('toc.oscar.aol.com', 9898) at 16717d0>
2009-09-06 12:23:57-0700 [aimBot,client] 
                                           MYUSERNAME
2009-09-06 12:23:57-0700 [aimBot,client] toc_signon login.oscar.aol.com 5190  MYUSERNAME 0x161e0b4d20169760 english "penguin"

The account never appears online.

twisted.words.protocols.toc was deprecated in #3580.

Attachments (2)

mypatch.patch (1.9 KB) - added by Poincare 7 years ago.
review
removeaimbot-4007.diff (2.6 KB) - added by Drew Smathers 7 years ago.
Remove aimbot.py example and ref in docs

Download all attachments as: .zip

Change History (23)

comment:1 Changed 8 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

What about rewriting it with twisted.words.protocols.oscar instead?

comment:2 Changed 8 years ago by ivank

Keywords: documentation easy review added

oscardemo.py already does that, I think.

comment:3 Changed 8 years ago by ivank

Owner: Jean-Paul Calderone deleted

comment:4 Changed 8 years ago by Jean-Paul Calderone

Cc: Jean-Paul Calderone added
Keywords: review removed
Owner: set to ivank

I think this is premature. twisted.words.protocols.toc hasn't been deprecated in any release yet. It's probably useless, but the example should stay until the code itself is removed. That would be in 9.0+2.

Changed 7 years ago by Poincare

Attachment: mypatch.patch added

review

comment:5 Changed 7 years ago by njoyce

Cc: njoyce added
Keywords: review added

Now that #3580 is fixed and twisted.words.protocols.toc is deprecated, the attached patch appears to do the job.

comment:6 Changed 7 years ago by njoyce

Owner: ivank deleted

comment:7 Changed 7 years ago by Drew Smathers

Owner: set to Drew Smathers
Status: newassigned

Changed 7 years ago by Drew Smathers

Attachment: removeaimbot-4007.diff added

Remove aimbot.py example and ref in docs

comment:8 Changed 7 years ago by Drew Smathers

Cc: Drew Smathers added
Owner: changed from Drew Smathers to Jean-Paul Calderone
Status: assignednew

Updated a patch with reference removed in documentation. If twisted.words.protocols.toc was supposed to removed in 9.0+2 maybe it's due time to really remove it considering current 10.0 release?

comment:9 Changed 7 years ago by Drew Smathers

Priority: normalhighest

comment:10 Changed 7 years ago by Jean-Paul Calderone

Keywords: review removed
Priority: highestlow

We need to wait a bit longer on this. 9.0 was released in December, three months ago. We can think about this for the release around December 2010.

comment:11 Changed 7 years ago by Allister MacLeod

Keywords: easy removed

This ticket depends on #4363 (remove TOC)

comment:12 Changed 6 years ago by Thijs Triemstra

Author: thijs
Branch: branches/remove-aimbot-4007

(In [30527]) Branching to 'remove-aimbot-4007'

comment:13 Changed 6 years ago by Thijs Triemstra

(In [30528]) Apply removeaimbot-4007.diff. refs #4007

comment:14 Changed 6 years ago by Thijs Triemstra

(In [30529]) add news file. refs #4007

comment:15 Changed 6 years ago by Thijs Triemstra

Author: thijsdjroofy, thijs
Description: modified (diff)
Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:16 Changed 6 years ago by Ying Li

Keywords: review removed
Owner: set to Thijs Triemstra

This only seems to remove the content of the aimbot.py file. Could you remove the file itself?

Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

comment:17 Changed 6 years ago by Thijs Triemstra

Status: newassigned

Thanks for the review.

comment:18 Changed 6 years ago by Thijs Triemstra

(In [30538]) Actually remove file, refs #4007

comment:19 in reply to:  16 Changed 6 years ago by Thijs Triemstra

Replying to cyli:

This only seems to remove the content of the aimbot.py file. Could you remove the file itself?

Otherwise looks good to merge, as long as the documentation builder still works once the file is deleted.

Results for the documentation builder. I'll merge it after #4363 landed.

comment:20 Changed 6 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [30544]) Merge remove-aimbot-4007: Removed the non-working AIM bot example, depending on the obsolete twisted.words.protocols.toc functionality.

Author: thijs, djroofy Reviewer: cyli Fixes: #4007

comment:21 Changed 6 years ago by <automation>

Owner: Thijs Triemstra deleted
Note: See TracTickets for help on using tickets.