Opened 7 years ago

Last modified 13 months ago

#3996 defect new

fix all instances of log.err() that take just a string as an argument.

Reported by: jesstess Owned by:
Priority: normal Milestone:
Component: core Keywords: logging
Cc: jesstess, thijs Branch:

Description (last modified by thijs)

log.err() is called with just one string all over the place even though the first parameter, _stuff, is type: NoneType?, Exception, or Failure according to the docs. Say the docs, _stuff "will be wrapped in a Failure". However:

from twisted.python import failure
main__:1: DeprecationWarning?: Don't pass strings (like 'Test') to failure.Failure (replacing with a DefaultException?).
<twisted.python.failure.Failure <class 'twisted.python.failure.DefaultException?'>>

so to skirt the DeprecationWarning and future unwanted behavior something else needs to be done with the strings to these log.err instances.

Change History (3)

comment:1 Changed 7 years ago by thijs

  • Cc thijs added
  • Description modified (diff)

Fixing description markup

comment:2 Changed 5 years ago by <automation>

  • Owner jesstess deleted

comment:3 Changed 13 months ago by wsanchez

  • Keywords logging added
Note: See TracTickets for help on using tickets.