Ticket #3996 defect new

Opened 5 years ago

Last modified 5 years ago

fix all instances of log.err() that take just a string as an argument.

Reported by: jesstess Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: jesstess, thijs Branch:
Author: Launchpad Bug:

Description (last modified by thijs) (diff)

log.err() is called with just one string all over the place even though the first parameter, _stuff, is type: NoneType?, Exception, or Failure according to the docs. Say the docs, _stuff "will be wrapped in a Failure". However:

from twisted.python import failure
failure.Failure("Test")
main__:1: DeprecationWarning?: Don't pass strings (like 'Test') to failure.Failure (replacing with a DefaultException?).
<twisted.python.failure.Failure <class 'twisted.python.failure.DefaultException?'>>

so to skirt the DeprecationWarning and future unwanted behavior something else needs to be done with the strings to these log.err instances.

Change History

1

Changed 5 years ago by thijs

  • cc thijs added
  • description modified (diff)

Fixing description markup

2

Changed 3 years ago by <automation>

  • owner jesstess deleted
Note: See TracTickets for help on using tickets.