t.i._pollingfile silently accepts unicode for writing

[dotz]

Hi,

this little bug took me about 3 hours to track. I use tx ampoule  https://launchpad.net/ampoule on win32 (Vista). Some AMP commands were passed correctly over ampoule; some were not and it looked like every single byte was separated by a NULL byte... As it came out, unicode string was passed to t.i._pollingfile write function and the AMP command sent by ampoule and Twisted amp was received mangled.

I propose we disallow writing unicode objects. If user wants to write unicode, he/she will have to convert it to utf-8 string before.

[dotz]

disable unicode for _pollingfile

[dotz]

Do you need anything else from me to get this one small change merged?

[glyph]

Tests, and the removal of the usage of "assert" (IIRC it's against the coding standard).

Thanks!

[dotz]

Patch with no assert and an unit test

[dotz]

New patch added. I hope that this will allow you to fix this. Thanks for your time!

[therve]

(In [27467]) Branching to 'pollingfile-unicode-3930'

[therve]

Merged in r27469, thanks for the patch!