Ticket #3895 (closed defect: fixed)

Opened 14 months ago

Last modified 13 months ago

twisted.words.protocols.irc.IRCClient.mode docstring claims "#" will be prepended to channel name if it is not already there, but it will not be

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone:
Component: words Keywords: documentation easy
Cc: Branch:
Author: Launchpad Bug:

Description

This part of the docstring should just be deleted, I think. As far as I can tell, this was never the behavior of this API.

Attachments

words-protocols-irc-IRCClient-mode.patch Download (0.6 KB) - added by jesstess 13 months ago.

Change History

Changed 13 months ago by jesstess

Changed 13 months ago by jesstess

  • owner exarkun deleted
  • keywords easy, review added; easy removed

Changed 13 months ago by ivank

I looked very closely at irc.py. The patch looks correct. Someone with SVN access should merge. I'm leaving the review keyword so that this doesn't get lost.

Changed 13 months ago by exarkun

  • owner set to exarkun
  • keywords easy added; easy, review removed

Thanks. You should probably remove the review keyword for this sort of thing in the future, or at least assign the ticket to a committer. Also, would you like commit access?

Changed 13 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [27231]) Apply words-protocols-irc-IRCClient-mode.patch fixing misinformation in IRCClient.mode docstring

Author: jesstess Reviewer: ivank Fixes: #3895

Remove the lies in IRCClient.mode's docstring which claimed non-channel targets would be forced to be channels.

Note: See TracTickets for help on using tickets.