Ticket #3895 (closed defect: fixed )

Opened 8 months ago

Last modified 6 months ago

twisted.words.protocols.irc.IRCClient.mode docstring claims "#" will be prepended to channel name if it is not already there, but it will not be

Reported by: exarkun Assigned to: exarkun
Type: defect Priority: normal
Milestone: Component: words
Keywords: documentation easy Cc:
Branch: Author:
Launchpad Bug:

Description

This part of the docstring should just be deleted, I think. As far as I can tell, this was never the behavior of this API.

Attachments

words-protocols-irc-IRCClient-mode.patch (0.6 kB) - added by jesstess 6 months ago.

Change History

  2009-08-13 18:48:33+00:00 changed by jesstess

  • attachment words-protocols-irc-IRCClient-mode.patch added

  2009-08-13 18:50:54+00:00 changed by jesstess

  • keywords changed from documentation easy to documentation easy, review
  • owner deleted

  2009-08-15 10:47:06+00:00 changed by ivank

I looked very closely at irc.py. The patch looks correct. Someone with SVN access should merge. I'm leaving the review keyword so that this doesn't get lost.

  2009-08-16 22:05:29+00:00 changed by exarkun

  • keywords changed from documentation easy, review to documentation easy
  • owner set to exarkun

Thanks. You should probably remove the review keyword for this sort of thing in the future, or at least assign the ticket to a committer. Also, would you like commit access?

  2009-08-16 22:28:55+00:00 changed by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [27231]) Apply words-protocols-irc-IRCClient-mode.patch fixing misinformation in IRCClient.mode docstring

Author: jesstess Reviewer: ivank Fixes: #3895

Remove the lies in IRCClient.mode's docstring which claimed non-channel targets would be forced to be channels.

Note: See TracTickets for help on using tickets.