Opened 8 years ago

Closed 8 years ago

#3832 enhancement closed fixed (fixed)

twisted.test.test_process.MockOS doesn't completely mock the os module

Reported by: z3p Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/mockos-3832
branch-diff, diff-cov, branch-cov, buildbot
Author: z3p

Description (last modified by Jean-Paul Calderone)

It depends on several attributes of the os module, which causes test failures on win32 (see branches/spwd-3242-2). I suppose it might be better to just skip the tests, but the only part that's breaking the tests is the use of the os.* attributes in __init__.

I'm attaching a quick patch which removes the dependency on the os module.

Attachments (1)

patch-3832.diff (724 bytes) - added by z3p 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by z3p

Attachment: patch-3832.diff added

comment:1 Changed 8 years ago by Jean-Paul Calderone

Description: modified (diff)

Fixing description markup.

comment:2 Changed 8 years ago by Glyph

Owner: changed from Glyph to z3p

comment:3 Changed 8 years ago by z3p

Author: z3p
Branch: branches/mockos-3832

(In [27071]) Branching to 'mockos-3832'

comment:4 Changed 8 years ago by z3p

Keywords: review added
Owner: z3p deleted
Priority: normalhighest

I applied the ticket in the branch. The tests still pass for me; I'm not sure if this requires new tests or not.

comment:5 Changed 8 years ago by therve

Keywords: review removed
Owner: set to z3p
Priority: highestnormal

Cool, please merge.

comment:6 Changed 8 years ago by z3p

Resolution: fixed
Status: newclosed

Fixed by r27080 (even though I typoed the commit message)

comment:7 Changed 7 years ago by <automation>

Owner: z3p deleted
Note: See TracTickets for help on using tickets.