Opened 7 years ago

Closed 7 years ago

#3832 enhancement closed fixed (fixed)

twisted.test.test_process.MockOS doesn't completely mock the os module

Reported by: z3p Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/mockos-3832
(github, coverage, patch, buildbot, log)
Author: z3p

Description (last modified by exarkun)

It depends on several attributes of the os module, which causes test failures on win32 (see branches/spwd-3242-2). I suppose it might be better to just skip the tests, but the only part that's breaking the tests is the use of the os.* attributes in __init__.

I'm attaching a quick patch which removes the dependency on the os module.

Attachments (1)

patch-3832.diff (724 bytes) - added by z3p 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by z3p

comment:1 Changed 7 years ago by exarkun

  • Description modified (diff)

Fixing description markup.

comment:2 Changed 7 years ago by glyph

  • Owner changed from glyph to z3p

comment:3 Changed 7 years ago by z3p

  • Author set to z3p
  • Branch set to branches/mockos-3832

(In [27071]) Branching to 'mockos-3832'

comment:4 Changed 7 years ago by z3p

  • Keywords review added
  • Owner z3p deleted
  • Priority changed from normal to highest

I applied the ticket in the branch. The tests still pass for me; I'm not sure if this requires new tests or not.

comment:5 Changed 7 years ago by therve

  • Keywords review removed
  • Owner set to z3p
  • Priority changed from highest to normal

Cool, please merge.

comment:6 Changed 7 years ago by z3p

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by r27080 (even though I typoed the commit message)

comment:7 Changed 5 years ago by <automation>

  • Owner z3p deleted
Note: See TracTickets for help on using tickets.