Some Flash Player installers may crash on XP when launched by Twisted
|Reported by:||ivank||Owned by:||ivank|
One of my Windows processes was having strange crashes. I narrowed it down to Twisted setting the full path as the first argument.
_callProtocolWithDeferred looks like this:
def _callProtocolWithDeferred(protocol, executable, args, env, path, reactor=None): if reactor is None: from twisted.internet import reactor d = defer.Deferred() p = protocol(d) reactor.spawnProcess(p, executable, (executable,)+tuple(args), env, path) return d
reactor.spawnProcess(p, executable, (executable,)+tuple(args), env, path)
should probably be
reactor.spawnProcess(p, executable, (os.path.split(executable),)+tuple(args), env, path)
_callProtocolWithDeferred the full executable path.
Change History (16)
comment:13 Changed 7 years ago by
|Summary:||t.i.utils._callProtocolWithDeferred passes full executable path as first argument → Some Flash Player installers may crash on XP when launched by Twisted|