Stop using twisted.test.time_helpers in twisted.test.test_internet

[exarkun]

time_helpers is basically deprecated. We should stop using it internally and formally deprecate it.

[drake]

Changed twisted.test.test_internet to use twisted.internet.task.Clock and deprecated time_helpers.py

[exarkun]

Hmm. The test, testCallLaterDelayAndReset used to be a test for the IReactorTime implementation in twisted.internet.base.ReactorBase. With these changes, it's now a test for twisted.internet.task.Clock.

I think the test needs to be moved into twisted.internet.test.test_base and written as a test against ReactorBase (or a subclass which adds a fake implementation of seconds and probably doIteration).

The easy keyword was probably a mistake for this ticket.

[exarkun]

(In [27930]) Branching to 'deprecate-time-helpers-3719'

[exarkun]

(In [27931]) Remove testCallLaterDelayAndReset and replace it with a bunch of tests in twisted.internet.test.test_posixbase

refs #3719

[exarkun]

(In [27932]) Deprecate time_helpers

refs #3719

[exarkun]

(In [27933]) News file for the deprecation

refs #3719

[thijs]

twisted/test/test_timehelpers.py needs an @since.

[exarkun]

Hmm. Nah. I don't think any test module needs one of those. They're not part of the public API, and we don't generate API docs for them.

Anything else?

[jesstess]

• time_helpers, test_internet, and test_posixbase need copyright bumps.
• In TimeoutReportReactor: I don't understand this sentence fragment: "A reactor which is just barely runnable, but which cannot monitor any readers or writers,". Should the 'but' be an 'and'?
• In IterationTimeoutTests: two lines between _checkIterationTimeout and test_noCalls

Other than that, +1 to merge.

[exarkun]

(In [28036]) Update copyright dates

refs #3719

[exarkun]

(In [28039]) Merge deprecate-time-helpers-3719

Author: drake, exarkun Reviewer: thijs, jesstess Fixes: #3719

Rewrite the last of the remaining tests which used twisted.test.time_helpers and deprecate that module.