Ticket #3717 enhancement closed fixed

Opened 4 years ago

Last modified 4 years ago

Delete the __main__ in twisted/protocols/postfix.py

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/postfix-main-3717
(diff, github, buildbot, log)
Author: thijs, cary Launchpad Bug:

Description

If there is supposed to be a runnable script, it should be a separate, real thing. With tests. Etc.

Attachments

postfix.patch Download (0.7 KB) - added by cary 4 years ago.

Change History

Changed 4 years ago by cary

1

follow-up: ↓ 3   Changed 4 years ago by cary

  • owner glyph deleted
  • keywords review added

2

  Changed 4 years ago by thijs

  • branch set to branches/postfix-main-3717
  • branch_author set to thijs

(In [26546]) Branching to 'postfix-main-3717'

3

in reply to: ↑ 1   Changed 4 years ago by thijs

  • status changed from new to assigned
  • cc thijs added
  • owner set to thijs
  • keywords review removed

Replying to cary:

What about moving it into something like trunk/twisted/doc/core/examples/postfix.py instead?

4

  Changed 4 years ago by thijs

(In [26548]) Add postfix sample refs #3717

5

  Changed 4 years ago by thijs

  • owner thijs deleted
  • status changed from assigned to new
  • keywords review added
  • branch_author changed from thijs to thijs, cary

6

  Changed 4 years ago by exarkun

  • owner set to exarkun
  • keywords review removed

Looks pretty good. Some minor coding standard issues should be addressed in postfix.py. I'm going to do that now.

7

  Changed 4 years ago by exarkun

(In [26568]) Update copyright date, module docstring formatting, and import ordering

refs #3717

8

  Changed 4 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [26573]) Merge postfix-main-3717

Author: cary, thijs Reviewer: exarkun Fixes: #3717

Move the __main__ out of twisted/protocols/postfix.py into a separate example script.

9

  Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.