Opened 8 years ago

Closed 8 years ago

#3717 enhancement closed fixed (fixed)

Delete the __main__ in twisted/protocols/postfix.py

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/postfix-main-3717
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs, cary

Description

If there is supposed to be a runnable script, it should be a separate, real thing. With tests. Etc.

Attachments (1)

postfix.patch (747 bytes) - added by cary 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by cary

Attachment: postfix.patch added

comment:1 Changed 8 years ago by cary

Keywords: review added
Owner: Glyph deleted

comment:2 Changed 8 years ago by Thijs Triemstra

Author: thijs
Branch: branches/postfix-main-3717

(In [26546]) Branching to 'postfix-main-3717'

comment:3 in reply to:  1 Changed 8 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to Thijs Triemstra
Status: newassigned

Replying to cary:

What about moving it into something like [source:trunk/twisted/doc/core/examples]/postfix.py instead?

comment:4 Changed 8 years ago by Thijs Triemstra

(In [26548]) Add postfix sample refs #3717

comment:5 Changed 8 years ago by Thijs Triemstra

Author: thijsthijs, cary
Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

comment:6 Changed 8 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks pretty good. Some minor coding standard issues should be addressed in postfix.py. I'm going to do that now.

comment:7 Changed 8 years ago by Jean-Paul Calderone

(In [26568]) Update copyright date, module docstring formatting, and import ordering

refs #3717

comment:8 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [26573]) Merge postfix-main-3717

Author: cary, thijs Reviewer: exarkun Fixes: #3717

Move the __main__ out of twisted/protocols/postfix.py into a separate example script.

comment:9 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.