Opened 5 years ago

Closed 5 years ago

#3717 enhancement closed fixed (fixed)

Delete the __main__ in twisted/protocols/postfix.py

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/postfix-main-3717
(diff, github, buildbot, log)
Author: thijs, cary Launchpad Bug:

Description

If there is supposed to be a runnable script, it should be a separate, real thing. With tests. Etc.

Attachments (1)

postfix.patch (747 bytes) - added by cary 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by cary

comment:1 follow-up: Changed 5 years ago by cary

  • Keywords review added
  • Owner glyph deleted

comment:2 Changed 5 years ago by thijs

  • Author set to thijs
  • Branch set to branches/postfix-main-3717

(In [26546]) Branching to 'postfix-main-3717'

comment:3 in reply to: ↑ 1 Changed 5 years ago by thijs

  • Cc thijs added
  • Keywords review removed
  • Owner set to thijs
  • Status changed from new to assigned

Replying to cary:

What about moving it into something like trunk/twisted/doc/core/examples/postfix.py instead?

comment:4 Changed 5 years ago by thijs

(In [26548]) Add postfix sample refs #3717

comment:5 Changed 5 years ago by thijs

  • Author changed from thijs to thijs, cary
  • Keywords review added
  • Owner thijs deleted
  • Status changed from assigned to new

comment:6 Changed 5 years ago by exarkun

  • Keywords review removed
  • Owner set to exarkun

Looks pretty good. Some minor coding standard issues should be addressed in postfix.py. I'm going to do that now.

comment:7 Changed 5 years ago by exarkun

(In [26568]) Update copyright date, module docstring formatting, and import ordering

refs #3717

comment:8 Changed 5 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [26573]) Merge postfix-main-3717

Author: cary, thijs
Reviewer: exarkun
Fixes: #3717

Move the __main__ out of twisted/protocols/postfix.py into a separate example
script.

comment:9 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.