Ticket #3712 enhancement closed fixed

Opened 4 years ago

Last modified 4 years ago

Delete the __main__ in twisted/names/root.py

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: names Keywords: easy
Cc: thijs Branch: branches/root-main-3712
Author: thijs, cary Launchpad Bug:

Description

This file isn't meant to be used as a script. There are also no tests for this behavior. Also it's using a soon-to-be-deprecated API. We can add a real script to do name resolution with twisted.names later, if we want.

Attachments

root.patch Download (0.7 KB) - added by cary 4 years ago.

Change History

Changed 4 years ago by cary

1

Changed 4 years ago by cary

  • keywords easy, review added; easy removed
  • owner exarkun deleted

2

Changed 4 years ago by thijs

  • branch set to branches/root-main-3712
  • branch_author set to thijs

(In [26552]) Branching to 'root-main-3712'

3

Changed 4 years ago by thijs

(In [26553]) Apply root.patch, refs #3712

4

Changed 4 years ago by thijs

  • keywords easy added; easy, review removed
  • cc thijs added
  • status changed from new to assigned
  • owner set to thijs
  • branch_author changed from thijs to thijs, cary

5

Changed 4 years ago by thijs

  • keywords easy, review added; easy removed
  • status changed from assigned to new
  • owner thijs deleted

6

Changed 4 years ago by exarkun

  • owner set to exarkun
  • keywords easy added; easy, review removed

Looks good. I'm going to make a couple minor coding standard updates to the changed file.

7

Changed 4 years ago by exarkun

(In [26565]) Update copyright date, remove unused imports

refs #3712

8

Changed 4 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [26569]) Merge root-main-3712

Author: cary Reviewer: thijs, exarkun Fixes: #3712

Remove the __main__ from twisted/names/root.py.

9

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.