Opened 5 years ago

Closed 5 years ago

#3710 enhancement closed fixed (fixed)

deprecate twisted.names.client.ThreadedResolver in favor of twisted.internet.base.ThreadedResolver

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: names Keywords: deprecation
Cc: Branch: branches/deprecate-threadedresolver-3710
(diff, github, buildbot, log)
Author: cary, exarkun Launchpad Bug:

Description

We've basically decided that twisted.internet.base.ThreadedResolver is public now, despite the slight unfortunateness that implies. So we can just point people at that.

Attachments (1)

client.patch (807 bytes) - added by cary 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by cary

  • Keywords review added
  • Owner exarkun deleted

Changed 5 years ago by cary

comment:2 Changed 5 years ago by cary

  • Keywords deprecation added
  • Owner set to dreid

comment:3 Changed 5 years ago by exarkun

  • Keywords review removed
  • Owner changed from dreid to exarkun

This should have a test, too.

comment:4 Changed 5 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/deprecate-threadedresolver-3710

(In [26638]) Branching to 'deprecate-threadedresolver-3710'

comment:5 Changed 5 years ago by exarkun

(In [26639]) Apply cary's patch to deprecate ThreadedResolver

refs #3710

comment:6 Changed 5 years ago by exarkun

(In [26640]) test the deprecation; make it be the right type and point at the right code

refs #3710

comment:7 Changed 5 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

comment:8 Changed 5 years ago by exarkun

  • Author changed from exarkun to cary, exarkun

comment:9 Changed 5 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Cool, please merge.

comment:10 Changed 5 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [26656]) Merge deprecate-threadedresolver-3710

Author: cary, exarkun
Reviewer: therve
Fixes: #3710

Deprecate twisted.names.client.ThreadedResolver in favor of
twisted.internet.base.ThreadedResolver.

comment:11 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.