Ticket #3710 enhancement closed fixed

Opened 5 years ago

Last modified 5 years ago

deprecate twisted.names.client.ThreadedResolver in favor of twisted.internet.base.ThreadedResolver

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: names Keywords: deprecation
Cc: Branch: branches/deprecate-threadedresolver-3710
(diff, github, buildbot, log)
Author: cary, exarkun Launchpad Bug:

Description

We've basically decided that twisted.internet.base.ThreadedResolver is public now, despite the slight unfortunateness that implies. So we can just point people at that.

Attachments

client.patch Download (0.8 KB) - added by cary 5 years ago.

Change History

1

Changed 5 years ago by cary

  • keywords review added
  • owner exarkun deleted

Changed 5 years ago by cary

2

Changed 5 years ago by cary

  • keywords deprecation, added
  • owner set to dreid

3

Changed 5 years ago by exarkun

  • owner changed from dreid to exarkun
  • keywords deprecation added; deprecation, review removed

This should have a test, too.

4

Changed 5 years ago by exarkun

  • branch set to branches/deprecate-threadedresolver-3710
  • branch_author set to exarkun

(In [26638]) Branching to 'deprecate-threadedresolver-3710'

5

Changed 5 years ago by exarkun

(In [26639]) Apply cary's patch to deprecate ThreadedResolver

refs #3710

6

Changed 5 years ago by exarkun

(In [26640]) test the deprecation; make it be the right type and point at the right code

refs #3710

7

Changed 5 years ago by exarkun

  • owner exarkun deleted
  • keywords deprecation, review added; deprecation removed

8

Changed 5 years ago by exarkun

  • branch_author changed from exarkun to cary, exarkun

9

Changed 5 years ago by therve

  • keywords deprecation added; deprecation, review removed
  • owner set to exarkun

Cool, please merge.

10

Changed 5 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [26656]) Merge deprecate-threadedresolver-3710

Author: cary, exarkun Reviewer: therve Fixes: #3710

Deprecate twisted.names.client.ThreadedResolver in favor of twisted.internet.base.ThreadedResolver.

11

Changed 3 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.