Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3709 defect closed fixed (fixed)

Several twisted.conch.test.test_checkers.SSHProtocolCheckerTestCase test methods fail when PyCrypto is unavailable

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: Branch: branches/conch-tests-without-crypto-3709
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

This can be seen on the without-modules builder:

http://buildbot.twistedmatrix.com/builders/py2.5-without-modules

Also, some of the test methods are misnamed (using underscores instead of camel case) and one is missing a docstring.

Attachments (1)

patch 3909.diff (3.1 KB) - added by christianmlong 6 years ago.
Added skips, cleaned up test names

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by christianmlong

Added skips, cleaned up test names

comment:1 Changed 6 years ago by christianmlong

  • Keywords review added; easy removed
  • Owner z3p deleted

comment:2 Changed 6 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/conch-tests-without-crypto-3709

(In [26635]) Branching to 'conch-tests-without-crypto-3709'

comment:3 Changed 6 years ago by exarkun

(In [26636]) Apply patch to skip tests which cannot run without PyCrypto

refs #3709

comment:4 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [26637]) Merge conch-tests-without-crypto-3709

Author: christianmlong
Reviewer: exarkun
Fixes: #3709

Skip some more Conch tests which depend on PyCrypto when PyCrypto is not
installed.

comment:5 Changed 6 years ago by exarkun

  • Keywords review removed

comment:6 Changed 4 years ago by <automation>

Note: See TracTickets for help on using tickets.