Twisted 8.2.0 requires pywin32
|Reported by:||amaury||Owned by:|
branch-diff, diff-cov, branch-cov, buildbot
|Author:||exarkun, Christian Long|
On Windows, if pywin32 is not installed, it is impossible to import Twisted:
Python 2.6.1 (r261:69718, Feb 17 2009, 15:28:19) [MSC v.1400 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> from twisted.internet import defer Traceback (most recent call last): File "<stdin>", line 1, in <module> File "c:\prod\python\lib\site-packages\twisted-8.2.0-py2.6-win32.egg\twisted\internet\defer.py", l ine 17, in <module> from twisted.python import log, failure, lockfile File "c:\prod\python\lib\site-packages\twisted-8.2.0-py2.6-win32.egg\twisted\python\lockfile.py", line 28, in <module> from win32api import OpenProcess ImportError: No module named win32api
This is unfortunate for simple applications, which don't use the DeferredFilesystemLock. And this makes Twisted usage by pypy much harder...
I suggest to make this dependency optional. For example, if pywin32 cannot be imported, we could assume that the other process is still running. I attach a patch along this idea.
Change History (16)
Changed 8 years ago by amaury
comment:1 Changed 8 years ago by christianmlong
- Keywords review added
- Owner changed from glyph to christianmlong