Opened 6 years ago

Closed 5 years ago

#3677 defect closed fixed (fixed)

twisted.internet.test.test_posixbase.TCPPortTests.test_connectionLostFailed runs against nonsensical reactors

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/tcp-test-posixbase-3677
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

If the test suite is run with a reactor not based on twisted.internet.posixbase, twisted.internet.test.test_posixbase.TCPPortTests still runs and uses that reactor. This means the test might fail. This is useless, since it's not intended to work on non-posixbase reactors. It needs to be skipped or made to create its own posixbase-derived reactor instance.

Change History (6)

comment:1 Changed 5 years ago by therve

  • Owner changed from glyph to therve

comment:2 Changed 5 years ago by therve

  • Author set to therve
  • Branch set to branches/tcp-test-posixbase-3677

(In [27006]) Branching to 'tcp-test-posixbase-3677'

comment:3 Changed 5 years ago by therve

  • Keywords review easy added
  • Owner therve deleted

I added a simple skip, please review.

comment:4 Changed 5 years ago by mwh

  • Keywords review easy removed
  • Owner set to therve

Looks fine to me, please land!

comment:5 Changed 5 years ago by therve

  • Resolution set to fixed
  • Status changed from new to closed

(In [27018]) Merge tcp-test-posixbase-3677

Author: therve
Reviewer: mwh
Fixes #3677

Skip tests expecting a PosixReactorBase variant on non-PosixReactorBase
reactors (ie iocp).

comment:6 Changed 4 years ago by <automation>

  • Owner therve deleted
Note: See TracTickets for help on using tickets.