Ticket #3677 defect closed fixed

Opened 4 years ago

Last modified 4 years ago

twisted.internet.test.test_posixbase.TCPPortTests.test_connectionLostFailed runs against nonsensical reactors

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/tcp-test-posixbase-3677
Author: therve Launchpad Bug:

Description

If the test suite is run with a reactor not based on twisted.internet.posixbase, twisted.internet.test.test_posixbase.TCPPortTests still runs and uses that reactor. This means the test might fail. This is useless, since it's not intended to work on non-posixbase reactors. It needs to be skipped or made to create its own posixbase-derived reactor instance.

Change History

1

Changed 4 years ago by therve

  • owner changed from glyph to therve

2

Changed 4 years ago by therve

  • branch set to branches/tcp-test-posixbase-3677
  • branch_author set to therve

(In [27006]) Branching to 'tcp-test-posixbase-3677'

3

Changed 4 years ago by therve

  • keywords review easy added
  • owner therve deleted

I added a simple skip, please review.

4

Changed 4 years ago by mwh

  • keywords review easy removed
  • owner set to therve

Looks fine to me, please land!

5

Changed 4 years ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [27018]) Merge tcp-test-posixbase-3677

Author: therve Reviewer: mwh Fixes #3677

Skip tests expecting a PosixReactorBase variant on non-PosixReactorBase reactors (ie iocp).

6

Changed 2 years ago by <automation>

  • owner therve deleted
Note: See TracTickets for help on using tickets.