Opened 9 years ago

Last modified 6 years ago

#3628 defect assigned

"Asynchronous Programming With Twisted" says that reactor.run and reactor.stop are "not usual" but don't explain what is

Reported by: radix Owned by: Thijs Triemstra
Priority: normal Milestone:
Component: core Keywords: documentation twistd
Cc: khorn, Thijs Triemstra Branch:
Author:

Description

First of all, they *are* usual - they're the usual ways to manage the reactor if you're using the reactor API to do it. I *assume* the document is talking about 'twistd', but it doesn't mention the tool once in the entire document.

Either these assertions need to be qualified with an explanation of twistd, or they should be removed entirely.

Attachments (1)

async.patch (906 bytes) - added by cary 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by cary

Owner: changed from Glyph to cary

comment:2 Changed 8 years ago by cary

Keywords: review added
Owner: cary deleted

I rephrased these comments. Attempting to explain twistd in this context would probably confuse folks.

Changed 8 years ago by cary

Attachment: async.patch added

comment:3 Changed 8 years ago by cary

Owner: set to David Reid

comment:4 Changed 8 years ago by cary

Owner: David Reid deleted

comment:5 Changed 8 years ago by Glyph

Keywords: review removed
Owner: set to cary

Please wrap the comments to 80 columns; in examples, it's even more important than usual, since preformatted text tends to run off the margin of a browser pretty easily.

I think it would also be helpful to add a reference to the Twisted plugins system to the 'see also' at the bottom of the document, explaining that larger programs typically do not call reactor.run themselves.

You might also want to have a look at the work that has gone into #1490, which might help to obviate the need for reactor.run all over the place in example code.

comment:6 Changed 8 years ago by khorn

Cc: khorn added

comment:7 Changed 7 years ago by Jean-Paul Calderone

Keywords: twistd added

comment:8 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Owner: changed from cary to Thijs Triemstra
Status: newassigned
Note: See TracTickets for help on using tickets.