Ticket #3619 task closed fixed

Opened 5 years ago

Last modified 5 years ago

Fix the "import minidom as microdom" stuff in lore

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: lore Keywords: easy
Cc: Branch: branches/lore-microdom-imports-3619
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

#3560 switched lore from microdom to minidom. To avoid lots and lots of extra diff, it left lore using the name "microdom" in most places, but made that actually refer to minidom.

Change all of the names used in Lore to minidom to make the code less confusing.

Change History

1

Changed 5 years ago by exarkun

  • keywords easy added

2

Changed 5 years ago by exarkun

  • branch set to branches/lore-microdom-imports-3619
  • branch_author set to exarkun

(In [26745]) Branching to 'lore-microdom-imports-3619'

3

Changed 5 years ago by exarkun

  • owner spiv deleted
  • keywords review added

I actually changed all the names to dom rather than minidom. Maybe this will afford us some more flexibility in changing to yet another DOM implementation in the future! Or maybe it doesn't matter.

Anyway I changed all the names and the  tests all still pass.

4

Changed 5 years ago by glyph

  • owner set to exarkun
  • keywords review removed

dom is still used as a parameter name a bunch of times in twisted.lore.lint, once in twisted.lore.slides, and as a variable in both of those modules as well as twisted.lore.latex.

But if the tests still pass once you've renamed those, go ahead and land it. Alternately, rename the import to something else, like 'minidom' as originally planned.

5

Changed 5 years ago by exarkun

(In [26928]) Rename this variable from dom to doc to avoid name collision with global

refs #3619

6

Changed 5 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [26929]) Merge lore-microdom-imports-3619

Author: exarkun Reviewer: glyph Fixes: #3619

Change the minidom as microdom imports in Twisted Lore to be minidom as dom instead, and adjust all affected code.

7

Changed 3 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.