Ticket #3604 enhancement closed duplicate
Create a single definitive module for commonly used test helpers and consolidate usage from existing test modules
|Reported by:||exarkun||Owned by:|
There is crazy sprawl in our test suite of "utilities":
- twisted/test/testutils.py - some random garbage, probably mostly PB related, but not really documented well enough that one could use it
- twisted/test/ssl_helpers.py - some context factories; why would anyone even need these? we have context factories already.
- twisted/test/time_helpers.py - essentially just a deprecated module with an old implementation of Clock
- twisted/test/proto_helpers.py - probably the most widely used helper module; the stuff it contains could be seriously better than it is, though
There's probably lots of duplication in individual test_*.py files as well. This makes maintenance harder. It makes writing new tests harder, since it's hard to find existing utilities and often we end up just re-writing them from scratch, usually with bugs. There should be exactly one module in Twisted for this kind of code and all of our test utilities should be in it.