Ticket #3540 task closed fixed

Opened 5 years ago

Last modified 4 years ago

Release Twisted 8.2

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: ralphm Branch: /branches/releases/release-8.2.x-3540
Author: Launchpad Bug:

Description


Change History

1

  Changed 5 years ago by glyph

Please coordinate with itamar to resolve #3543 as well.

2

  Changed 4 years ago by radix

  • keywords review added
  • owner radix deleted

3

  Changed 4 years ago by radix

  • branch set to releases/release-8.2.x-3540

Ready for review.

4

  Changed 4 years ago by exarkun

  • owner set to exarkun
  • status changed from new to assigned
  • branch changed from releases/release-8.2.x-3540 to /branches/releases/release-8.2.x-3540

5

follow-up: ↓ 6   Changed 4 years ago by exarkun

  • owner changed from exarkun to radix
  • keywords review removed
  • status changed from assigned to new
  1. twisted/conch/topfiles/NEWS - first line of the Fixes section talks about "1789" instead of "#1789"
  2. It looks like pair, flow, and runner are going to be released, but they have no news file entries. Are there actually any changes since 8.0.0?
  3. twisted/names/topfiles/NEWS has two Fixes items which refer to #3342. I guess that's okay, if it was intentional, which I guess it probably was.
  4. twisted/news/topfiles/NEWS has no entries for 8.2. There have been some minor changes, but I guess nothing worth summarizing. It might be confusing to not have an 8.2 section in the news file though? otoh, maybe no one will notice.
  5. twisted/topfiles/NEWS - #2820 is mentioned, but it ended up being re-opened
  6. twisted/internet/_sslverify.py - the extra copyright lines probably aren't necessary. At the very least, the third one shouldn't be added.

6

in reply to: ↑ 5   Changed 4 years ago by ralphm

Replying to exarkun:

6. twisted/internet/_sslverify.py - the extra copyright lines probably aren't necessary. At the very least, the third one shouldn't be added.

This is a result of the current version of trunk, which has three copyright statements. The file in the branch only has two. I added the last line in my branch and then someone came by and also 'fixed' the copyrights before my branch got merged. I didn't notice that when I merged to trunk.

In any case I believe it should become this:

# Copyright (c) 2005 Divmod, Inc.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.
# See LICENSE for details.

7

  Changed 4 years ago by ralphm

  • cc ralphm added

8

  Changed 4 years ago by radix

  • owner changed from radix to exarkun
  • keywords review added

Ok, mostly resolved, but I have a couple questions (#2 and #4).

1. Fixed

2. Yeah, there weren't any changes to those projects. Given that we have a unified release procedure, it's actually harder to *not* release new versions of all projects. What do you think we should do? Should I just put "No interesting changes" in their NEWS files?

3. Yeah, it was intentional. I wanted to give them separate lines because they seemed like they were fixing different problems.

4. Yeah, the only changes that I saw were project-wide stuff which I've documented in the core NEWS file. I guess this is a case similar to #2. What do you think?

5. Removed

6. I only see two copyright lines in _sslverify.py right now. Maybe someone fixed it in this branch already? If not, can you paste exactly what you're seeing?

9

  Changed 4 years ago by exarkun

  • keywords review removed
  • owner changed from exarkun to radix

2/4 - Okay. I wasn't sure, since it seems like for the 8.1 release we did something different. Adding "No interesting changes" to the relevant subproject news files sounds like the right solution.

6 - When I merge the branch into trunk, the first 6 lines of _sslverify.py are thus:

# -*- test-case-name: twisted.test.test_sslverify -*-
# Copyright (c) 2005 Divmod, Inc.
# Copyright (c) 2008 Twisted Matrix Laboratories.
# See LICENSE for details.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.

10

  Changed 4 years ago by radix

  • keywords review added
  • owner radix deleted

2/4 : Ok, I added the stub entries.

6: The content in the branch itself doesn't look like that. What the hell, SVN? Well, I can't merge forward to fix it, so we'll just have to remember to resolve that issue when we merge to trunk.

11

  Changed 4 years ago by exarkun

  • keywords review removed
  • owner set to radix

+1

12

  Changed 4 years ago by radix

  • status changed from new to closed
  • resolution set to fixed

(In [25735]) Merge release-8.2.0-3540

Author: radix Reviewer: exarkun Fixes: #3540

NEWS file and version updates from the release of Twisted 8.2.0.

13

  Changed 2 years ago by <automation>

  • owner radix deleted
Note: See TracTickets for help on using tickets.