Opened 6 years ago

Closed 6 years ago

#3540 task closed fixed (fixed)

Release Twisted 8.2

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: ralphm Branch: /branches/releases/release-8.2.x-3540
(diff, github, buildbot, log)
Author: Launchpad Bug:

Description


Change History (13)

comment:1 Changed 6 years ago by glyph

Please coordinate with itamar to resolve #3543 as well.

comment:2 Changed 6 years ago by radix

  • Keywords review added
  • Owner radix deleted

comment:3 Changed 6 years ago by radix

  • Branch set to releases/release-8.2.x-3540

Ready for review.

comment:4 Changed 6 years ago by exarkun

  • Branch changed from releases/release-8.2.x-3540 to /branches/releases/release-8.2.x-3540
  • Owner set to exarkun
  • Status changed from new to assigned

comment:5 follow-up: Changed 6 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to radix
  • Status changed from assigned to new
  1. twisted/conch/topfiles/NEWS - first line of the Fixes section talks about "1789" instead of "#1789"
  2. It looks like pair, flow, and runner are going to be released, but they have no news file entries. Are there actually any changes since 8.0.0?
  3. twisted/names/topfiles/NEWS has two Fixes items which refer to #3342. I guess that's okay, if it was intentional, which I guess it probably was.
  4. twisted/news/topfiles/NEWS has no entries for 8.2. There have been some minor changes, but I guess nothing worth summarizing. It might be confusing to not have an 8.2 section in the news file though? otoh, maybe no one will notice.
  5. twisted/topfiles/NEWS - #2820 is mentioned, but it ended up being re-opened
  6. twisted/internet/_sslverify.py - the extra copyright lines probably aren't necessary. At the very least, the third one shouldn't be added.

comment:6 in reply to: ↑ 5 Changed 6 years ago by ralphm

Replying to exarkun:

  1. twisted/internet/_sslverify.py - the extra copyright lines probably aren't necessary. At the very least, the third one shouldn't be added.

This is a result of the current version of trunk, which has three copyright statements. The file in the branch only has two. I added the last line in my branch and then someone came by and also 'fixed' the copyrights before my branch got merged. I didn't notice that when I merged to trunk.

In any case I believe it should become this:

# Copyright (c) 2005 Divmod, Inc.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.
# See LICENSE for details.

comment:7 Changed 6 years ago by ralphm

  • Cc ralphm added

comment:8 Changed 6 years ago by radix

  • Keywords review added
  • Owner changed from radix to exarkun

Ok, mostly resolved, but I have a couple questions (#2 and #4).

  1. Fixed
  1. Yeah, there weren't any changes to those projects. Given that we have a unified release procedure, it's actually harder to *not* release new versions of all projects. What do you think we should do? Should I just put "No interesting changes" in their NEWS files?
  1. Yeah, it was intentional. I wanted to give them separate lines because they seemed like they were fixing different problems.
  1. Yeah, the only changes that I saw were project-wide stuff which I've documented in the core NEWS file. I guess this is a case similar to #2. What do you think?
  1. Removed
  1. I only see two copyright lines in _sslverify.py right now. Maybe someone fixed it in this branch already? If not, can you paste exactly what you're seeing?

comment:9 Changed 6 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to radix

2/4 - Okay. I wasn't sure, since it seems like for the 8.1 release we did something different. Adding "No interesting changes" to the relevant subproject news files sounds like the right solution.

6 - When I merge the branch into trunk, the first 6 lines of _sslverify.py are thus:

# -*- test-case-name: twisted.test.test_sslverify -*-
# Copyright (c) 2005 Divmod, Inc.
# Copyright (c) 2008 Twisted Matrix Laboratories.
# See LICENSE for details.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.
# Copyright (c) 2005-2008 Twisted Matrix Laboratories.

comment:10 Changed 6 years ago by radix

  • Keywords review added
  • Owner radix deleted

2/4 : Ok, I added the stub entries.

6: The content in the branch itself doesn't look like that. What the hell, SVN? Well, I can't merge forward to fix it, so we'll just have to remember to resolve that issue when we merge to trunk.

comment:11 Changed 6 years ago by exarkun

  • Keywords review removed
  • Owner set to radix

+1

comment:12 Changed 6 years ago by radix

  • Resolution set to fixed
  • Status changed from new to closed

(In [25735]) Merge release-8.2.0-3540

Author: radix
Reviewer: exarkun
Fixes: #3540

NEWS file and version updates from the release of Twisted 8.2.0.

comment:13 Changed 4 years ago by <automation>

  • Owner radix deleted
Note: See TracTickets for help on using tickets.