Added microsecond to formatTime

[wangchun]

The current formatTime implementation cannot format some time zone string correctly.

For busy servers, timestamp with microsecond is useful to administrators understand what was happened from log files.

Currently, user cannot give format string to reproduce the default format. We should make the time format more flexible and customizable by the user. Any ideas?

[exarkun]

You can subclass FileLogObserver and override formatTime. That wouldn't be much harder than replacing the time format with a new string.

Most cases won't benefit from having microseconds in the log, so I don't think that data should be included by default.

Maybe time.strftime should gain a new format character for this value?

[wangchun]

You are right, but the code would look a bit hacking, since FileLogObserver is hard coded in startLogging.

Perhaps we can find some way to do it without having to subclass the observer. There is a Formatter class in Python's logging module.

[exarkun]

#638 is a ticket for making it possible to customize the logging configuration used by twistd. That would address the problem of FileLogObserver being hard coded in startLogging.

[exarkun]

I filed #3515 for the small negative tzoffset bug.

[zseil]

add timezone info support to LogFileObservers

[zseil]

datetime.datetime.strftime() in Python 2.6 accepts a new %f format character, which expands to the number of microseconds. So I used this as an excuse to convert all time manipulation in FileLogObserver to datetime module objects. The patch adds a new method getTimezoneInfo to FileLogObserver, which controls the current local time. It also always uses the datetime.strftime() method for time formating. The default time format is unchanged, but now that #3534 has landed it should be easier to change timeFormat used by twistd.

[therve]

The patch attached as little to do with the current ticket. It would be better to open a new one.

[zseil]

Ok, I opened #3546.

[exarkun]

#6219 was a duplicate of this.

[exarkun]

(In [36644]) Branching to 'datetime-strftime-3513'

[exarkun]

Just switched to using datetime.datetime.strftime instead of time.strftime. The former seems to be a superset of the latter, just adding %f (microseconds) and %z (timezone offset). It's probably a bit slower too.

 Build results

[tom.prince]

Apparently timedelta.total_seconds is only available in python 2.7:

exceptions.AttributeError: 'datetime.timedelta' object has no attribute 'total_seconds'

so that hunk should be reverted.

Also, the documentation of formatTime needs to updated to reflect the changed underlying function.

Please commit after those changes and a green buildbot run.

[exarkun]

(In [36699]) Merge datetime-strftime-3513

Author: exarkun Reviewer: tom.prince Fixes: #3513

Switch from time.strftime to datetime.datetime.strftime for formatting log message timestamps, adding support for microseconds and timezone offsets.