deprecate --extra option to trial

[exarkun]

It serves no useful purpose any longer.

[glyph]

Specifically, its purpose as described in its usage documentation is now accomplished by the --testmodule option.

This ticket raises an interesting issue though. I don't think there should ever be a 'deprecate X' ticket without a parallel 'remove X' ticket, at least until the removals are automated. I filed #3374 in an attempt to keep it on our radar.

(Also I'm lowering the priority because I really hope that we have more useful things to do than remove trivial options. Don't interpret it as a signal that it should not be done though; the option is kind of silly, and I don't know of any other use-cases for it.)

[cyli]

(In [30444]) Branching to 'remove-trial-extra-3372'

[cyli]

(In [30446]) Twisted coding standard compliance

refs #3372

[cyli]

So "remove-trial-extra" may be an inaccurate branch description. Nevertheless...  build results

[thijs]

• The man page needs a copyright update:

  Copyright \(co 2003-2010 Twisted Matrix Laboratories
  

• can you also update the copyright in twisted.version.copyright? There's not really a policy that says it should be updated when working on a ticket that touches that part of the code (like a release) so you might as well do it here.

Cheers

[cyli]

(In [30453]) Updated several copyrights

refs #3372

[cyli]

(In [30454]) Oops, one more copyright.

refs #3372

[cyli]

Not sure what you meant by twisted.version.copyright, so updated both twisted.python.versions 's copyright, and twisted.copyright.

[thijs]

Replying to cyli:

Not sure what you meant by twisted.version.copyright,

Sorry I meant twisted.copyright.copyright

so updated both twisted.python.versions 's copyright, and twisted.copyright.

even better, thanks.

[exarkun]

Files that get changed should get their copyright date updated. Random extra files should not (including twisted/copyright.py which will get updated during a release).

[cyli]

so... should I change both back?

[exarkun]

If you want to, it would be preferable, but it teeters on the edge of not-worth-it. Mainly I want to clear up whether something similar should ever be done for another ticket (no it should not).

[exarkun]

1. in ExtraTests, assertEquals is preferred over assertEqual
2. Existing deprecations use Version("Twisted", ...) rather than Version("twisted", ...). I even feel like this made a real difference at some point, but I can't quite remember what the case was.

Otherwise looks good.

[cyli]

(In [30490]) Rollback extra copyright changes

refs #3372

[cyli]

(In [30494]) Merge remove-trial-extra-3372: deprecate --extra option to trial

Author: cyli Reviewer: thijs, exarkun Fixes: #3372

Deprecate --extra option to trial

[cyli]

(In [30502]) Reverse the merge because changing 'twisted' to 'Twisted' in Versions causes a failure in one of the new tests

reopens #3372

[cyli]

(In [30503]) Changed the 'twisted' in Version to 'Twisted'

refs #3372

[cyli]

(In [30506]) Merge remove-trial-extra-3372: deprecate --extra option to trial

Author: cyli Reviewer: thijs, exarkun Fixes: #3372

Deprecate --extra option to trial