Opened 6 years ago

Closed 4 years ago

#3372 task closed fixed (fixed)

deprecate --extra option to trial

Reported by: exarkun Owned by: cyli
Priority: low Milestone:
Component: trial Keywords: easy
Cc: cyli, thijs Branch: branches/remove-trial-extra-3372
(diff, github, buildbot, log)
Author: cyli Launchpad Bug:

Description

It serves no useful purpose any longer.

Change History (19)

comment:1 Changed 6 years ago by glyph

  • Priority changed from normal to low

Specifically, its purpose as described in its usage documentation is now accomplished by the --testmodule option.

This ticket raises an interesting issue though. I don't think there should ever be a 'deprecate X' ticket without a parallel 'remove X' ticket, at least until the removals are automated. I filed #3374 in an attempt to keep it on our radar.

(Also I'm lowering the priority because I really hope that we have more useful things to do than remove trivial options. Don't interpret it as a signal that it should not be done though; the option is kind of silly, and I don't know of any other use-cases for it.)

comment:2 Changed 4 years ago by thijs

  • Cc cyli thijs added
  • Owner changed from jml to cyli

comment:3 Changed 4 years ago by cyli

  • Author set to cyli
  • Branch set to branches/remove-trial-extra-3372

(In [30444]) Branching to 'remove-trial-extra-3372'

comment:4 Changed 4 years ago by cyli

(In [30446]) Twisted coding standard compliance

refs #3372

comment:5 Changed 4 years ago by cyli

  • Keywords easy review added
  • Owner cyli deleted

So "remove-trial-extra" may be an inaccurate branch description. Nevertheless... build results

comment:6 Changed 4 years ago by thijs

  • Keywords review removed
  • Owner set to cyli
  • The man page needs a copyright update:
    Copyright \(co 2003-2010 Twisted Matrix Laboratories
    
  • can you also update the copyright in twisted.version.copyright? There's not really a policy that says it should be updated when working on a ticket that touches that part of the code (like a release) so you might as well do it here.

Cheers

comment:7 Changed 4 years ago by cyli

(In [30453]) Updated several copyrights

refs #3372

comment:8 Changed 4 years ago by cyli

(In [30454]) Oops, one more copyright.

refs #3372

comment:9 follow-up: Changed 4 years ago by cyli

  • Keywords review added
  • Owner cyli deleted

Not sure what you meant by twisted.version.copyright, so updated both twisted.python.versions 's copyright, and twisted.copyright.

comment:10 in reply to: ↑ 9 Changed 4 years ago by thijs

Replying to cyli:

Not sure what you meant by twisted.version.copyright,

Sorry I meant twisted.copyright.copyright

so updated both twisted.python.versions 's copyright, and twisted.copyright.

even better, thanks.

comment:11 Changed 4 years ago by exarkun

Files that get changed should get their copyright date updated. Random extra files should not (including twisted/copyright.py which will get updated during a release).

comment:12 Changed 4 years ago by cyli

so... should I change both back?

comment:13 Changed 4 years ago by exarkun

If you want to, it would be preferable, but it teeters on the edge of not-worth-it. Mainly I want to clear up whether something similar should ever be done for another ticket (no it should not).

comment:14 Changed 4 years ago by exarkun

  • Keywords review removed
  • Owner set to cyli
  1. in ExtraTests, assertEquals is preferred over assertEqual
  2. Existing deprecations use Version("Twisted", ...) rather than Version("twisted", ...). I even feel like this made a real difference at some point, but I can't quite remember what the case was.

Otherwise looks good.

comment:15 Changed 4 years ago by cyli

(In [30490]) Rollback extra copyright changes

refs #3372

comment:16 Changed 4 years ago by cyli

  • Resolution set to fixed
  • Status changed from new to closed

(In [30494]) Merge remove-trial-extra-3372: deprecate --extra option to trial

Author: cyli
Reviewer: thijs, exarkun
Fixes: #3372

Deprecate --extra option to trial

comment:17 Changed 4 years ago by cyli

  • Resolution fixed deleted
  • Status changed from closed to reopened

(In [30502]) Reverse the merge because changing 'twisted' to 'Twisted' in Versions causes a failure in one of the new tests

reopens #3372

comment:18 Changed 4 years ago by cyli

(In [30503]) Changed the 'twisted' in Version to 'Twisted'

refs #3372

comment:19 Changed 4 years ago by cyli

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [30506]) Merge remove-trial-extra-3372: deprecate --extra option to trial

Author: cyli
Reviewer: thijs, exarkun
Fixes: #3372

Deprecate --extra option to trial

Note: See TracTickets for help on using tickets.