Opened 6 years ago

Closed 6 years ago

#3370 defect closed fixed (fixed)

twisted.internet.test.reactormixins.ReactorBuilder.runReactor leaks state on glib2 and gtk2

Reported by: exarkun Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: Branch: branches/reactorbuilder-cleanup-more-3370
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

It seems glib2 and gtk2 reactors live forever and can interfer with later tests. ReactorBuilder needs to do some extra work to clean these up, perhaps by cancelling all their outstanding DelayedCalls.

Change History (6)

comment:1 Changed 6 years ago by exarkun

  • author set to exarkun
  • Branch set to branches/reactorbuilder-cleanup-more-3370

(In [24405]) Branching to 'reactorbuilder-cleanup-more-3370'

comment:2 Changed 6 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted
  • Priority changed from high to highest

Okay, should be fixed. You can observe the problem by running trial -u twisted.internet.test.test_tls and letting it go for two minutes. It will die right around the two minute mark. It should run indefinitely with the changes in the branch.

comment:3 Changed 6 years ago by washort

  • Owner set to exarkun

I get the same results here. Looks good to merge.

comment:4 Changed 6 years ago by washort

  • Keywords review removed

comment:5 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [24419]) Merge reactorbuilder-cleanup-more-3370

Author: exarkun
Reviewer: washort
Fixes: #3370

Add code to cancel all pending timed events to the reactor
cleanup code in twisted.internet.test.reactormixins so
that they don't remain to interfere with future tests.

comment:6 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.