Opened 6 years ago

#3294 enhancement new

twisted.conch.ssh.session.wrapProcessProtocol is a no-op in the only circumstance it is used under

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

wrapProcessProtocol takes one argument. If the argument is an instance of Protocol, it returns something else. Otherwise, it returns exactly its argument. The only time wrapProcessProtocol is called (in session.py), it is passed an instance of SSHSessionProcessProtocol, which is not an instance of Protocol. So the call has no effect. There are no other calls in Twisted to the function. The call should be removed, the function deprecated, and later it should be removed.

Change History (1)

comment:1 Changed 3 years ago by <automation>

  • Owner z3p deleted
Note: See TracTickets for help on using tickets.