#3228 enhancement new
Conch SFTP should translate errors in ISFTPServer implementation, not in SFTP protocol
|Reported by:||jml||Owned by:|
Currently, Conch has a great deal of error translation code in _ebStatus on FileTransferServer. Much of this code translates OS errors into SFTP error messages. This is kind of OK, but it mixes concerns. The ISFTPServer implementation is the thing that knows about the filesystem.
- the ISFTPServer implementation should be responsible for translating errors from IOError, OSError etc.
- FileTransferServer should expect only SFTPErrors to be raised by ISFTPServer (along with good handling for unexpected errors).
- The unix SFTP implementation should do its own error translation.
- (if we care), The ISFTPServer adapter for twisted.vfs should translate its errors to SFTPError not IOError.