428: DeprecationWarning: use loseWriteConnection instead

[JimD]

Regarding line 428 of:

http://twistedmatrix.com/trac/browser/trunk/twisted/conch/scripts/conch.py?rev=23479

Apparently fixed by:

--- /usr/local/src/conch.py     2008-05-02 17:02:11.000000000 -0700
+++ /usr/lib/python2.5/site-packages/twisted/conch/scripts/conch.py     2006-01-17 12:49:40.000000000 -0800
@@ -425,7 +425,7 @@
 
     def eofReceived(self):
         log.msg('got eof')
-        self.stdio.loseWriteConnection()
+        self.stdio.closeStdin()
     
     def closeReceived(self):
         log.msg('remote side closed %s' % self)

[launchpad]

Updating Launchpad bug reference

[exarkun]

fixing description markup

[exarkun]

The patch is backward. It's closeStdin that's used and deprecated and loseWriteConnection which ought to be used instead.

[exarkun]

(In [25757]) Branching to 'conch-losewriteconnection-3220'

[exarkun]

Build results:

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/conch-losewriteconnection-3220

[therve]

Please merge.

[exarkun]

(In [25881]) Merge conch-losewriteconnection-3220

Author: JimD, exarkun Reviewer: therve Fixes: #3220

Replace the use of the deprecated StandardIO.closeStdin with use of the equivalent StandardIO.loseWriteConnection. This eliminates a deprecation warning when a Conch SSH session ends.