Opened 6 years ago

Closed 6 years ago

#3220 defect closed fixed (fixed)

428: DeprecationWarning: use loseWriteConnection instead

Reported by: JimD Owned by:
Priority: normal Milestone:
Component: conch Keywords: DeprecationWarning
Cc: Branch: branches/conch-losewriteconnection-3220
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug: 225574

Description (last modified by exarkun)

Regarding line 428 of:

http://twistedmatrix.com/trac/browser/trunk/twisted/conch/scripts/conch.py?rev=23479

Apparently fixed by:

--- /usr/local/src/conch.py     2008-05-02 17:02:11.000000000 -0700
+++ /usr/lib/python2.5/site-packages/twisted/conch/scripts/conch.py     2006-01-17 12:49:40.000000000 -0800
@@ -425,7 +425,7 @@
 
     def eofReceived(self):
         log.msg('got eof')
-        self.stdio.loseWriteConnection()
+        self.stdio.closeStdin()
     
     def closeReceived(self):
         log.msg('remote side closed %s' % self)

Change History (8)

comment:1 Changed 6 years ago by launchpad

  • Launchpad Bug set to 225574

Updating Launchpad bug reference

comment:2 Changed 6 years ago by exarkun

  • Description modified (diff)

fixing description markup

comment:3 Changed 6 years ago by exarkun

The patch is backward. It's closeStdin that's used and deprecated and loseWriteConnection which ought to be used instead.

comment:4 Changed 6 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/conch-losewriteconnection-3220

(In [25757]) Branching to 'conch-losewriteconnection-3220'

comment:6 Changed 6 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Please merge.

comment:7 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [25881]) Merge conch-losewriteconnection-3220

Author: JimD, exarkun
Reviewer: therve
Fixes: #3220

Replace the use of the deprecated StandardIO.closeStdin with use of the
equivalent StandardIO.loseWriteConnection. This eliminates a deprecation
warning when a Conch SSH session ends.

comment:8 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.