Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3139 defect closed fixed (fixed)

Broken link to pb.Root and friends in pb-usage documentation

Reported by: Glyph Owned by:
Priority: normal Milestone: Twisted-8.2
Component: core Keywords: documentation
Cc: Thijs Triemstra Branch:
Author:

Description

It seems like all the API documentation links on the web site are broken right now, but even if that issue were fixed, pb-usage.html either has the wrong class names for the things it's linking to or the links don't work.

See the original report of this problem in #38; we now have the tools to fix it in any way we want.

Attachments (1)

pb-root-3139.patch (837 bytes) - added by Thijs Triemstra 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Owner: changed from Glyph to Thijs Triemstra
Status: newassigned

comment:2 Changed 9 years ago by Glyph

Thank you, thank you, thank you for taking this ticket away from me. Please tell everyone else to steal tickets from me too :-).

Changed 9 years ago by Thijs Triemstra

Attachment: pb-root-3139.patch added

comment:3 Changed 9 years ago by Thijs Triemstra

Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

I added a patch that points the baseclass to the actual baseclass, twisted.spread.flavors in this case, but I'm not sure if this is the way to go, since we lose the reference to 'pb.Root' with just 'Root' instead. Let me know how to approach this with the 'tools' from #38..

comment:4 Changed 9 years ago by Jean-Paul Calderone

Keywords: review removed
Milestone: Twisted-8.2
Owner: set to radix

Hmm. I wonder why the link is still broken. I thought we resolved #38 in time for the last release.

I just regenerated the API documentation and twisted.spread.pb.Root.html exists now. So I think this will be resolved (automagically) when we regenerate the API docs (which will happen for the next release), without any changes to pb-usage.xhtml.

comment:5 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

8.2 released, new docs generated and on the site, the links work now.

comment:6 Changed 8 years ago by Jean-Paul Calderone

Milestone: Twisted-8.2+1Twisted-8.2

comment:7 Changed 6 years ago by <automation>

Owner: radix deleted
Note: See TracTickets for help on using tickets.