Make SSHProtocolTestCase easier to customize/reuse by another tests.

[jkk]

I've broken testOurServerOurClient into two other methods.One responible for server/client initiializiation and another for running connection between them. This allows one to customize server or client side classes without code duplication.

My use case is adding test for #3007.I would use testOurServerOurClient, but I need to use custom client class different from ConchTestClient().I can't do that without duplicating the code.With patch I would create a new method in SSHProtcolTestCase or it's subclass and change self.client.

[exarkun]

This seems like a fine refactoring to do. I've made a few changes to the patch to bring it in line with the coding standard (docstrings, whitespace, test method naming), but otherwise it looks good. However, this is such a small change I don't think it makes sense to do it separately from #3007. I suggest just including it in whatever patch you submit to resolve that ticket.

I'll attach the modified patch so you can use that.

If this makes sense to you, please close this ticket.

[jkk]

Thanks for a really quick response and feedback :) I'll use it in #3007.