Opened 10 years ago

Closed 10 years ago

#3058 enhancement closed fixed (fixed)

grok svn 1.4 information in twisted.python.versions

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: Branch: branches/svn14version-3058
branch-diff, diff-cov, branch-cov, buildbot
Author: glyph

Description

Currently only svn 1.3 internal details are recognized. 1.4 is in widespread use now (and 1.5 is coming pretty soon I guess maybe). It'd be nice to update this functionality a bit.

Attachments (1)

svn14.patch (790 bytes) - added by Glyph 10 years ago.
a bad joke about a solution to this issue

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Glyph

Attachment: svn14.patch added

a bad joke about a solution to this issue

comment:1 Changed 10 years ago by Glyph

author: glyph
Branch: branches/svn14version-3058

(In [22721]) Branching to 'svn14version-3058'

comment:2 Changed 10 years ago by Glyph

Keywords: review added
Owner: Jean-Paul Calderone deleted
Priority: lowhighest

A real solution is in the branch.

comment:3 Changed 10 years ago by therve

Keywords: review removed
Owner: set to Glyph

I tried hard to spot something, but it looks great. Please update the copyright notice of both files, then merge.

comment:4 Changed 10 years ago by Glyph

Resolution: fixed
Status: newclosed

(In [22725]) Update twisted.python.versions to understand version 8 of SVN "entries" files.

Fixes #3058

Author: glyph, exarkun

Reviewer: therve

For a long time now, twisted.python.versions has been giving back "rUnknown" for SVN checkouts. This updates it to understand the more recent format used by svn 1.4, as well as suggesting a very simple framework for dealing with future versions.

This also moves another test module out of twisted.test, continuing the slow process of depopulating that namespace and moving everything to dedicated test packages.

comment:5 Changed 7 years ago by <automation>

Owner: Glyph deleted
Note: See TracTickets for help on using tickets.