deprecated Resource subclasses in twisted.web.error, add equivalents in twisted.web.resource

[exarkun]

This circularity is dumb and it breaks tools (eg pydoctor).

Generally, error modules are for exceptions, anyway.

[exarkun]

(In [26020]) Branching to 'deprecate-error-pages-3035'

[exarkun]

Done, please review.

[glyph]

1. A number of tests emit the new warnings, such as:

   /home/glyph/Projects/Twisted/trunk/twisted/web/_auth/wrapper.py:120: DeprecationWarning: twisted.web.error.ErrorPage is deprecated since Twisted 9.0.  See twisted.web.resource.ErrorPage.
   

2. The moved resources should get docstrings.

[exarkun]

Replying to glyph:

1. A number of tests emit the new warnings, such as: {{{ /home/glyph/Projects/Twisted/trunk/twisted/web/_auth/wrapper.py:120: DeprecationWarning: twisted.web.error.ErrorPage is deprecated since Twisted 9.0. See twisted.web.resource.ErrorPage. }}}

Okay, I think I replaced all uses of the deprecated API with the non-deprecated API. Running the test suite like this:

PYTHONPATH= python -W 'error:twisted.web.error.ErrorPage is deprecated since Twisted 9.0.  See twisted.web.resource.ErrorPage.' -W 'error:twisted.web.error.NoResource is deprecated since Twisted 9.0.  See twisted.web.resource.NoResource.' -W 'error:twisted.web.error.ForbiddenResource is deprecated since Twisted 9.0.  See twisted.web.resource.ForbiddenResource.' ~/Projects/Twisted/branches/deprecate-error-pages-3035/bin/trial twisted

now produces no errors for me. I had to change a bunch of code with no unit tests, so I added some. I did not add tests for the Quixote stuff. Changes in r26031.

1. The moved resources should get docstrings.

Fixed in r26029.

[therve]

• Some flakes:

  twisted/web/test/test_cgi.py:7: 'static' imported but unused
  twisted/web/test/test_vhost.py:11: 'Resource' imported but unused
  twisted/web/twcgi.py:24: 'html' imported but unused
  

• The new deprecation warnings are missing tests.

[therve]

OK I missed some files :). +1.

[exarkun]

(In [26112]) remove unused imports; replace relative imports with absolute imports; update copyrights; add/reformat module docstrings

refs #3035

[exarkun]

(In [26114]) work around pydoctor bug; markup cannot span multiple lines :/

refs #3035

[exarkun]

(In [26115]) Skip 403 test on Windows

refs #3035

[exarkun]

Buildbot revealed some minor issues. I responded to review feedback and fixed the build issues in the revisions above. Merging now.

[exarkun]

(In [26116]) Merge deprecate-error-pages-3035

Author: exarkun Reviewer: glyph, therve Fixes: #3035

Move the error response resource classes from twisted.web.error to twisted.web.resource. This is the first step in eliminating the circular dependency between those two modules. Deprecated versions of the resources remain in twisted.web.error for backwards compatibility and numerous tests for these classes have been added.