Ticket #3030 (closed enhancement: fixed )

Opened 1 year ago

Last modified 1 year ago

The first parameter of twisted.internet.threads.blockingCallFromThread should be reactor

Reported by: exarkun Assigned to: exarkun
Type: enhancement Priority: highest
Milestone: twisted-8.0 Component: core
Keywords: Cc:
Branch: branches/blockingcallfromthread-arg-3030 Author: exarkun
Launchpad Bug:

Description

Global state is bad and stuff. Parameterization is great and stuff.

Any function which uses a global reactor variable should probably be parameterized instead.

This should happen before the next release, since it's not a compatible change. Fortunately blockingCallFromThread hasn't been part of any release yet.

Attachments

Change History

  2008-02-18 03:59:23+00:00 changed by exarkun

  • branch set to branches/blockingcallfromthread-arg-3030
  • author set to exarkun

(In [22588]) Branching to 'blockingcallfromthread-arg-3030'

  2008-02-18 04:00:21+00:00 changed by exarkun

  • keywords set to review
  • owner deleted
  • priority changed from normal to highest

  2008-02-18 13:01:32+00:00 changed by therve

  • keywords deleted
  • owner set to exarkun
  • I'm not sure making the reactor import at the top is a great change... whatever
  • please add a test-case-name to wsgi.py

Please merge once done.

  2008-02-18 15:32:01+00:00 changed by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [22598]) Merge blockingcallfromthread-arg-3030

Author: exarkun Reviewer: therve Fixes #3030

Change the signature of twisted.internet.threads.blockingCallFromThread to take the reactor into which it will call as the first parameter. Update the docs and the usage in twisted.web2 as well.

Note: See TracTickets for help on using tickets.