[PATCH] twisted.spread.util.FilePager doesn't callback when sending an empty file

[zectbumo]

If you use FilePager to send an empty file then the completion callback never gets called.

[zectbumo]

this also seems to fix it

[zectbumo]

I like patch 2 better since it is more straight forward

[therve]

Thanks for the patch. Some comments:

• while you're at it, please move Pager.__init__ in the first line of the __init__ method
• your empty file doesn't need to be created in the setUp method as it's only used in your test. Please move the creation in your test, make it a local variable, and makes it follow twisted naming standard (filenameEmpty instead of self.filename_empty)
• Use self.fail(msg) instead of raise Exception(msg)

Thanks!

[zectbumo]

Replying to therve:

* while you're at it, please move Pager.__init__ in the first line of the __init__ method

I wish I could. The problem gets bigger if I try that. Pager.init calls broker.registerPageProducer which eventually calls sendNextPage which needs a reference to self.chunks and self.chunks won't get initialize until after Pager.init. The problem comes down to that Pager.init is doing more than just initializing, it's also registering which causes wheels to start turning before we are done initializing.

* your empty file doesn't need to be created in the setUp method as it's only used in your test. Please move the creation in your test, make it a local variable, and makes it follow twisted naming standard (filenameEmpty instead of self.filename_empty) * Use self.fail(msg) instead of raise Exception(msg)

done

[therve]

Fixed in r22475.

[therve]

(In [22482]) Revert r22475: stupid print statement.

Refs #3023

[therve]

(In [22485]) Branching to 'filepager-empty-file-3023'

[therve]

(In [22486]) Apply the patch, without the print.

Refs #3023

[exarkun]

Humm okay. I wish the PB code and tests were nicer. :(

But a bug is fixed, so this should go in. Thanks, please merge.

[therve]

(In [22557]) Merge filepager-empty-file-3023

Authors: zectbumo, therve Reviewers: exarkun, therve Fixes #3023

Make twisted.spread.util.FilePager works with empty files: previously, it didn't callback correctly.