man2lore doesn't correctly translate .TP tags

[therve]

Basically, it means that the output of the list of options in xhtml is broken.

[therve]

(In [22432]) Branching to 'fix-man2lore-3017'

[therve]

(In [22433]) Fix and tests.

Refs #3017

[therve]

This is ready to review. man2lore would need one hundred time more tests, but I'm not sure I have the energy to do that right now. As it's a release blocker...

[exarkun]

eyes bleeding, etc. Thanks for tackling this. I won't ask for all the extra tests this code really needs, since the change to fix this issue is pretty small and the approach man2lore takes is completely wrong anyway...

Some stuff I think should be done, though:

• test-case-name for man2lore.py
• docstring for macro_TP and text methods of ManConverter, since they had changes
• documentation for the tp ivar of ManConverter
• Factor the common parts of the tests into a helper - writing to a file, calling convert, etc.

[therve]

(In [22439]) Process review comments.

Refs #3017.

[therve]

Thanks for the review. I think I fix everything, except the test-case-name which was already there :).

[exarkun]

Cool, thanks. ManConverter.tp is still pretty opaque to me though. Do you think you could document what each of the 4 values it can take on mean (I ask because I think you must have figured out at least some of them in order to make this change :)? This could either take the form of an expanded @ivar or maybe the constants could be replaced with symbolic names which have some meaning.

[therve]

(In [22459]) Document tp variable.

Refs #3017

[therve]

I choosed the verbose way, I hope this is clear enough. Back to review.

[exarkun]

Looks good, thanks. Please merge.

[therve]

(In [22460]) Merge fix-man2lore-3017

Author: therve Reviewer: exarkun Fixes #3017

Fix the conversion of the list of options in man pages to Lore format.