Opened 7 years ago

Closed 6 years ago

#2985 defect closed fixed (fixed)

twisted.web.static.FileTransfer pointlessly uses threadable.synchronized

Reported by: exarkun Owned by:
Priority: high Milestone:
Component: web Keywords:
Cc: Branch: branches/unsynchronized-2985
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

FileTransfer should not bother to pretend to provide a threadsafe API. Synchronizing resumeProducing doesn't actually make it threadsafe to call self.request.write from another thread.

Change History (5)

comment:1 Changed 6 years ago by exarkun

  • author set to exarkun
  • Branch set to branches/unsynchronized-2985

(In [23910]) Branching to 'unsynchronized-2985'

comment:2 Changed 6 years ago by exarkun

  • Keywords review added
  • Owner jknight deleted

Removed, and did some other minor cleanups.

comment:3 Changed 6 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Looks cool. There is a bunch of other cleanups which would be nice to make:

  • remove string import
  • remove future import
  • remove trailing whitespaces

Nothing mandatory though, so merge when you want.

comment:4 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [23946]) Merge unsynchronized-2985

Author: exarkun
Reviewer: therve
Fixes: #2985

Remove the code which synchronizes methods of FileTransfer. The methods
aren't threadsafe even if they're guaranteed to be serialized.

Also make some minor cleanups to nearby code, removing trailing whitespace
and no-longer needed imports.

comment:5 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.