Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#2981 defect closed fixed (fixed)

I can't seem to run the Twisted tests without hitting an intermittent failure on my Windows machine

Reported by: glyph Owned by:
Priority: high Milestone:
Component: core Keywords: discussion
Cc: therve, Trent.Nelson, exarkun Branch: branches/intermittent-2981
(diff, github, buildbot, log)
Author: glyph Launchpad Bug:

Description

Although our Windows buildslave reports test successes most of the time these days, I have found that the tests will fairly reliably hit at least one intermittent failure on my desktop installation of Windows.

I don't particularly like the scope of ticket, but one of my new years' resolutions is to avoid letting process anxieties get in the way of useful work. This ticket may just be closed as "invalid" eventually. For now it should serve as an anchor point to discuss the issues that I've found and link them to the appropriate, hopefully pre-existing tickets, and to give me a ticket number so I can make a branch to put the fixes I've made.

Change History (7)

comment:1 Changed 7 years ago by glyph

  • author set to glyph
  • Branch set to branches/intermittent-2981

(In [22288]) Branching to 'intermittent-2981'

comment:2 Changed 7 years ago by therve

  • Cc therve added

There is at least #2876 which is up to review. Also, you should run trial with the --unclean-warnings option to avoid those errors.

comment:3 follow-up: Changed 6 years ago by Trent.Nelson

  • Cc Trent.Nelson added

What sort of failures? I've been working on all kinds of stuff trying to address these sorts of things on the Python Windows buildbots. Biggest issue: file permissions. Second biggest issue: not using SO_EXCLUSIVEADDRUSE on every TCP/IP socket. Third biggest issue: using SO_REUSEADDR on Windows for anything but true multicast UDP sockets. Having tests hard code ports was pretty common in Python's test suite, that'll cause all sorts of problems obviously when tests are executing simultaneously -- I'm told you guys use ephemeral ports for client/server testing though so it's less of a problem.

comment:4 Changed 6 years ago by exarkun

  • Cc exarkun added
  • Priority changed from normal to high

The branch seems to contain fixes for these issues:

Please verify the above and then close this ticket and open a new one with details about the failures related to the test_tcp changes.

comment:5 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

All those other tickets have been resolved. There still may be something in test_tcp that hasn't been addressed. Please open a new ticket detailing that issue.

comment:6 in reply to: ↑ 3 Changed 5 years ago by davidsarah

Replying to Trent.Nelson:

Second biggest issue: not using SO_EXCLUSIVEADDRUSE on every TCP/IP socket.

I completely agree; this is a serious security issue (now #4195).

comment:7 Changed 4 years ago by <automation>

  • Owner glyph deleted
Note: See TracTickets for help on using tickets.