Opened 7 years ago

Closed 6 years ago

#2935 enhancement closed fixed (fixed)

Use FancyEqMixin and FancyStrMixin for all Record_* types and Name in twisted.names.dns

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: names Keywords:
Cc: therve Branch: branches/dns-str-eq-2935-3
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Many of them use one or both of these, but not all.

Change History (8)

comment:1 Changed 7 years ago by exarkun

  • author set to exarkun
  • Branch set to branches/dns-str-eq-2631

comment:2 Changed 6 years ago by therve

  • Cc therve added

What's the status of this? It would be cool if it could land, it helps unittests a lot.

comment:3 Changed 6 years ago by exarkun

  • Branch changed from branches/dns-str-eq-2631 to branches/dns-str-eq-2935-3

(In [23926]) Branching to 'dns-str-eq-2935-3'

comment:4 Changed 6 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

It was waiting for #2944, but that was finished a while ago I guess. Should be finished now.

comment:5 Changed 6 years ago by therve

  • Keywords review removed
  • Owner set to exarkun
  • in EqualityTests._equalityTest, can you add a comment about why you don't use assertEquals and friends? I probably know, but it's better to have written
  • there's an extra line after _equalityTest

Everything else is great, so please merge once both points addressed.

comment:6 Changed 6 years ago by exarkun

(In [23961]) whitespace and comment about implementation

refs #2935

comment:7 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [23962]) Merge dns-str-eq-2935-3

Author: exarkun
Reviewer: therve
Fixes: #2935

Define string representation and equality for all record types (using
FancyStrMixin and FancyEqMixin from twisted.python.util). Also
add tests for these behaviors.

comment:8 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.