conch gmpy support doesn't work anymore

[therve]

This fails with this error:

  File "twisted-trunk/twisted/conch/ssh/common.py", line 105, in _fastgetMP
    mp.append(long(gmpy.mpz(data[c+4:c+l+4][::-1]+'\x00')))
exceptions.ValueError: string without NULL characters expected

[therve]

It comes from [21670]... It's not the first problem spotted since this merge, I wonder if it shouldn't be reverted.

[exarkun]

One step in the right direction would be to get gmp onto at least one of the slaves. Then, there should be unit tests which run both versions of the code, even if gmp is installed.

[therve]

(In [21979]) Branching to 'conch-gmpy-support-2924'

[therve]

OK this is ready to review. Although it's useless until a slave got gmpy installed.

[exarkun]

bot-cube has gmpy available now

[exarkun]

The indentation in MPTestCase.test_multipleGetMP is a bit funny. The 2nd line of the string literal should be indented two spaces fewer than it is, I think.

It might be nice to have a test for an integer > 255.

Otherwise, nice fix, thanks.

As far as reverting the original branch goes, I think we probably missed that opportunity. :( I'm guessing that untangling what has happened since will be more work than just fixing the problems we find. Sorry for not being more rigorous on that review.

[therve]

(In [22121]) Fix indentation, add one test.

Refs #2924

[therve]

Thanks for the review, I've made the modifications.

Regarding the revert, the branch was big enough so it wasn't very easy to make it land. Sometimes we just have to go forward :).

[exarkun]

Looks good, please merge

[therve]

(In [22122]) Skip the tests when pyCrypto is not there.

Refs #2924

[therve]

(In [22123]) Merge conch-gmpy-support-2924

Author: therve Reviewer: exarkun Fixes #2924

Make gmpy support in conch works again, and add tests for both standard and fast implementation of multiple precision. It was broken in r21670.