twisted.test.test_defer.DeferredTestCase.testMaybeDeferred should be faster and four different tests
|Reported by:||exarkun||Owned by:|
(diff, github, buildbot, log)
testMaybeDeferred uses reactor.callLater(0.2 twice, making it take at least 0.4 seconds to run. This could easily be shortened so that it succeeds synchronously (it's trying to test the uncalled Deferred case for success and error, but it could do this by calling back the Deferred after maybeDeferred has gotten a hold of it).
It's also testing four different conditions, so it should be broken into separate test methods.
Change History (7)
comment:3 Changed 8 years ago by therve
- Cc therve added
- Keywords review added
- Owner glyph deleted
- Priority changed from normal to highest
comment:5 Changed 8 years ago by exarkun
- Keywords review removed
- Owner changed from exarkun to therve
- Status changed from assigned to new