Ticket #2894 enhancement closed fixed

Opened 6 years ago

Last modified 6 years ago

twisted.test.test_defer.DeferredTestCase.testMaybeDeferred should be faster and four different tests

Reported by: exarkun Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: therve Branch: branches/test-maybedeferred-2894
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

testMaybeDeferred uses reactor.callLater(0.2 twice, making it take at least 0.4 seconds to run. This could easily be shortened so that it succeeds synchronously (it's trying to test the uncalled Deferred case for success and error, but it could do this by calling back the Deferred after maybeDeferred has gotten a hold of it).

It's also testing four different conditions, so it should be broken into separate test methods.

Change History

1

Changed 6 years ago by therve

  • branch set to branches/test-maybedeferred-2894
  • author set to therve

(In [22091]) Branching to 'test-maybedeferred-2894'

2

Changed 6 years ago by therve

(In [22092]) Fix testMaybeDeferred: split it in 4, add some docstrings.

Refs #2894

3

Changed 6 years ago by therve

  • priority changed from normal to highest
  • cc therve added
  • owner glyph deleted
  • keywords review added

This is ready to review.

4

Changed 6 years ago by exarkun

  • status changed from new to assigned
  • owner set to exarkun

5

Changed 6 years ago by exarkun

  • keywords review removed
  • owner changed from exarkun to therve
  • status changed from assigned to new

Looks good

6

Changed 6 years ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [22179]) Merge test-maybedeferred-2894

Author: therve Reviewer: exarkun Fixes #2894

Split the tests of maybeDeferred into 4 smaller tests, and remove the callLater from the tests.

7

Changed 3 years ago by <automation>

  • owner therve deleted
Note: See TracTickets for help on using tickets.