Intermittent unclean errors from twisted.test.test_ftp.FTPServerPasvDataConnectionTestCase.testTwoDirLIST on OS X

[exarkun]

Seen occassionally:

===============================================================================
[ERROR]: twisted.test.test_ftp.FTPServerPasvDataConnectionTestCase.testTwoDirLIST

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 57837128 [599.546686888s] called=0 cancelled=0 FTP.__timedOut()>
===============================================================================
[ERROR]: twisted.test.test_ftp.FTPServerPasvDataConnectionTestCase.testTwoDirLIST

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
Selectables:
<ProtocolWrapper #0 on 61530>
<<class 'twisted.internet.tcp.Port'> of twisted.protocols.ftp.DTPFactory on 61538>
-------------------------------------------------------------------------------

[exarkun]

A cleanup error occurs on OS X with another FTP test as well:

===============================================================================
[ERROR]: twisted.test.test_ftp.BasicFTPServerTestCase.testAnonymousLoginDenied

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 72203320 [599.86994195s] called=0 cancelled=0 FTP.__timedOut()>
===============================================================================
[ERROR]: twisted.test.test_ftp.BasicFTPServerTestCase.testAnonymousLoginDenied

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
Selectables:
<ProtocolWrapper #0 on 57297>
-------------------------------------------------------------------------------

[exarkun]

(In [24790]) Branching to 'ftp-test-cleanup-2878'

[exarkun]

#3405 was a duplicate of this, for the testManyLargeDownloads method.

[exarkun]

I think this is fixed.

[therve]

Please merge.

[exarkun]

(In [24811]) Merge ftp-test-cleanup-2878

Author: exarkun Reviewer: therve Fixes: #2878

Change the setUp of one of the base FTP test cases so that the test will wait for the server-side of any FTP connection established in the test to disconnect before ending the test, avoiding leaving a selectable in the reactor for trial to find and emit an unclean error for.