Opened 7 years ago

Closed 7 years ago

#2876 defect closed fixed (fixed)

twisted.test.test_pb.NewCredTestCase.test_clientConnectionLost failing on windows

Reported by: exarkun Owned by:
Priority: highest Milestone:
Component: core Keywords: win32
Cc: therve Branch: branches/test-pb-reconnecting-2876
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

Windows slave configuration changed slightly (maybe a red herring). test_clientConnectionLost has errors now, on several Windows slaves:

===============================================================================
[ERROR]: twisted.test.test_pb.NewCredTestCase.test_clientConnectionLost

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 22763960 [29.9850001335s] called=0 cancelled=0 Client.failIfNotConnected(TimeoutError('',))>
===============================================================================
[ERROR]: twisted.test.test_pb.NewCredTestCase.test_clientConnectionLost

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
Selectables:
<<class 'twisted.internet.tcp.Client'> to ('127.0.0.1', 4176) at 32904f0>
-------------------------------------------------------------------------------

This happens on three builders covering two different versions of Windows and two different versions of Python.

Attachments (1)

2876.diff (1.5 KB) - added by therve 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by therve

Note that these are unclean errors, which probably explain why they didn't appear before.

comment:2 Changed 7 years ago by exarkun

  • Priority changed from highest to normal

Good point. I'm going to change the buildbot configuration so unclean errors are only warnings on the windows builders.

Changed 7 years ago by therve

comment:3 Changed 7 years ago by therve

  • author set to therve
  • Cc therve added
  • Keywords review added
  • Owner glyph deleted
  • Priority changed from normal to highest

The problem was that the factory was trying to reconnect even on the second disconnection. I also use assertIsInstance where necessary, and correct an error on the second test (the wrong object was checked). Please review.

comment:4 Changed 7 years ago by therve

  • Branch set to branches/test-pb-reconnecting-2876

(In [22793]) Branching to 'test-pb-reconnecting-2876'

comment:5 Changed 7 years ago by bigdog

  • Owner set to therve

I verified that the branch does no harm. The code seems reasonable and is covered by current test cases.

I ran the branch on windows and unix with no negative impact.

This code should be ready to go

comment:6 Changed 7 years ago by bigdog

  • Keywords review removed

comment:7 Changed 7 years ago by therve

  • Resolution set to fixed
  • Status changed from new to closed

(In [22796]) Merge test-pb-reconnecting-2876

Author: therve
Reviewer: bigdog
Fixes #2876

Fix unclean errors in
twisted.test.test_pb.NewCredTestCase.test_clientConnectionLost under win32.

comment:8 Changed 4 years ago by <automation>

  • Owner therve deleted
Note: See TracTickets for help on using tickets.