Ticket #2856 (closed enhancement: fixed )

Opened 2 years ago

Last modified 2 years ago

trial verbose color reporter should colorize final "PASSED" and "FAILED" message

Reported by: exarkun Assigned to: therve
Type: enhancement Priority: highest
Milestone: Component: trial
Keywords: Cc: therve, jml
Branch: Author:
Launchpad Bug:

Description

It'd be much easier to read the summary output if "PASSED" were green and "FAILED" were red, or maybe if the entire lines were colored according to that status information.

Attachments

Change History

  2007-10-25 12:19:47+00:00 changed by therve

  • owner changed from jml to therve

  2007-10-25 12:23:12+00:00 changed by therve

(In [21407]) Color the ouput and add tests for it.

Refs #2856

  2007-10-25 12:24:47+00:00 changed by therve

  • cc set to therve, jml
  • keywords set to review
  • owner deleted
  • priority changed from low to highest

That's a nice idea, implemented and ready to review in trial-colored-summary-2856. I choose to color only the main message, not the whole line.

  2007-10-25 12:39:01+00:00 changed by exarkun

  • keywords deleted
  • owner set to therve

It's too bad Reporter still has that stream attribute. :(

printSummary doesn't seem to be part of any interface. I guess this is the reporter object. The runner calls result.printSummary(), anyway, and I guess result is supposed to provide IReporter. But that's an existing problem, not a new one.

Doing if not wasSuccessful/FAILED instead of if wasSuccessful/PASSED is slightly round-about, but I see that's just how the parent implementation being overridden works. Plus it's not a very big deal in the first place...

I'm just nit picking basically, the branch looks great. Thanks!

  2007-10-25 13:03:13+00:00 changed by therve

  • status changed from new to closed
  • resolution set to fixed

(In [21410]) Merge trial-colored-summary-2856

Author: therve Reviewer: exarkun Fixes #2856

Make the trial colored verbose reporter colorize final PASSED and FAILED messages.

Note: See TracTickets for help on using tickets.