Opened 7 years ago

Closed 7 years ago

#2856 enhancement closed fixed (fixed)

trial verbose color reporter should colorize final "PASSED" and "FAILED" message

Reported by: exarkun Owned by:
Priority: highest Milestone:
Component: trial Keywords:
Cc: therve, jml Branch:
Author: Launchpad Bug:

Description

It'd be much easier to read the summary output if "PASSED" were green and "FAILED" were red, or maybe if the entire lines were colored according to that status information.

Change History (6)

comment:1 Changed 7 years ago by therve

  • Owner changed from jml to therve

comment:2 Changed 7 years ago by therve

(In [21407]) Color the ouput and add tests for it.

Refs #2856

comment:3 Changed 7 years ago by therve

  • Cc therve jml added
  • Keywords review added
  • Owner therve deleted
  • Priority changed from low to highest

That's a nice idea, implemented and ready to review in trial-colored-summary-2856. I choose to color only the main message, not the whole line.

comment:4 Changed 7 years ago by exarkun

  • Keywords review removed
  • Owner set to therve

It's too bad Reporter still has that stream attribute. :(

printSummary doesn't seem to be part of any interface. I guess this is the reporter object. The runner calls result.printSummary(), anyway, and I guess result is supposed to provide IReporter. But that's an existing problem, not a new one.

Doing if not wasSuccessful/FAILED instead of if wasSuccessful/PASSED is slightly round-about, but I see that's just how the parent implementation being overridden works. Plus it's not a very big deal in the first place...

I'm just nit picking basically, the branch looks great. Thanks!

comment:5 Changed 7 years ago by therve

  • Resolution set to fixed
  • Status changed from new to closed

(In [21410]) Merge trial-colored-summary-2856

Author: therve
Reviewer: exarkun
Fixes #2856

Make the trial colored verbose reporter colorize final PASSED and FAILED
messages.

comment:6 Changed 3 years ago by <automation>

  • Owner therve deleted
Note: See TracTickets for help on using tickets.