give TrafficLoggingFactory a public API to reset its counter

[exarkun]

TrafficLoggingFactory keeps track of how many connections have been made through it and uses this counter in constructing filenames to perform the logging. It would be useful, particularly for unit tests, if the counter could be reset to 0 via some public API.

In current trunk, twisted.test.test_policies.LoggingFactoryTestCase.testThingsGetLogged fails when run with trial -u since it doesn't account for the fact that the counter was incremented by a previous test.

[therve]

The work is done in trafficlogging-counter-2757.

[ralphm]

Looks good. Please merge.

[therve]

(In [20937]) Merge trafficlogging-counter-2757

Author: therve Reviewer: ralphm Close #2757

Add a resetCounter method to twisted.protocol.policies.TrafficLoggingFactory, used to reset the counter of connections to 0. Also, use this API in the tests so that they pass with the --until-failure flag of trial.

[therve]

(In [20942]) Revert r20937, wrong API defined.

Refs #2757

[therve]

Sorry we can do better.

[therve]

OK, I cleaned it up a bit in [20974]. That should be better.

[ralphm]

Maybe split out the test for _counter and and resetCounter. Otherwise seems to better, indeed.

I'd be ok with merging this.

[therve]

(In [20991]) Add a specific test for resetCounter.

Refs #2757.

[therve]

Thanks, I added another test. Still need a little review for the new docstrings.

[ralphm]

Works for me.

Please merge.

[therve]

(In [21000]) Merge trafficlogging-counter-2757

Author: therve Reviewer: ralphm Fixes #2757

Add a resetCounter method to twisted.protocol.policies.TrafficLoggingFactory, used to reset the counter of connections to 0. Also, refactor TrafficLoggingProtocol so that it gets its counter from the factory instead of holding it as a class variable.