Opened 7 years ago

Closed 3 years ago

#2736 defect closed wontfix (wontfix)

StreamProducer defer patch

Reported by: KyleJ Owned by:
Priority: normal Milestone:
Component: web2 Keywords: patch
Cc: Branch:
Author: Launchpad Bug:

Description

If a callback occurs after self.deferred is set to None in _doWrite (for instance: while the producer is paused) and returns a deferred None, StreamProducder halts early.

Patch (for trunk/twisted/web2/stream.py):

--- stream.py   2007-07-17 21:08:26.000000000 -0700
+++ stream2.py  2007-07-17 21:09:12.000000000 -0700
@@ -729,7 +729,7 @@
     
     def resumeProducing(self):
         self.paused = False
-        if self.deferred is not None:
+        if self.deferred is not None and self.deferred.result is not None:
             return
 
         try:

Change History (3)

comment:1 Changed 7 years ago by exarkun

Got a unit test?

comment:2 Changed 3 years ago by exarkun

  • Resolution set to wontfix
  • Status changed from new to closed

Not going to fix this in web2 (see #4821). Also I still don't quite understand how to trigger this behavior either. There are no streams in Twisted Web, so no parallel misbehavior, so not retargeting this at the web component.

comment:3 Changed 3 years ago by <automation>

  • Owner jknight deleted
Note: See TracTickets for help on using tickets.