twisted/web/proxy.py doesn't use IRequest.finish

[exarkun]

ProxyClient.handleResponseEnd uses loseConnection to disconnect the tcp session. It should be calling finish on the request, though.

[jack]

Specifically this manifested for me as ReverseProxyResource requests not appearing in the logs. I have not found a work around.

As reverse proxies are becoming extremely common due to JavaScript's same origin policy, perhaps the priority of this bug should be stepped up a little?

[glyph]

Given how infrequently sponsors have actually requested things, I'm giving this a bump :).

[exarkun]

(In [26716]) Branching to 'finish-proxied-requests-2677'

[exarkun]

Done, enjoyably.  Build results

[therve]

• There are some problems with 2.3, as you use sorted.
• The _finished flag isn't tested, apparently.
• Is the loseConnection call in handleResponseEnd still necessary? I suspect request.finish will do the right thing.

Thanks!

[exarkun]

(In [26723]) Python 2.3 compat

refs #2677

[exarkun]

(In [26724]) Add a test case which covers the duplicate protection in handleResponseEnd

refs #2677

[exarkun]

(In [26725]) Add a test for the loseConnection call

refs #2677

[exarkun]

Thanks for the review!

1. Replaced sorted with list.sort in r26723
2. Added a test which covers _finished in r26724
3. Added a test which requires the loseConnection call in order to pass in r26725 (it is necessary because it's the outgoing request's transport, whereas the request.finish() call will only deal with the incoming request's transport).

[therve]

Great, please merge.

[exarkun]

(In [26738]) Fix the error case test to assert something valid; fix the implementation to use the right request methods to report the error

refs #2677

[exarkun]

I made a mistake in one of the tests. It was asserting something nonsensical. Fixed in the above linked revision. Sorry about that.

[therve]

Fair enough, +1.

[exarkun]

(In [26744]) Merge finish-proxied-requests-2677

Author: exarkun Reviewer: therve Fixes: #2677

Use the incoming IRequest object in the HTTP proxy when generating a response to it rather than using its undocumented transport object. This makes the proxy more generally useful (as it might support custom request objects now), fixes a bug which led to proxied requests not being logged, and simplifies the proxy code slightly be removing the need for it to know much about the protocol-level formatting of HTTP.