Ticket #2656 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

twisted.protocols.amp.Command.makeResponse docstring inaccurate

Reported by: exarkun Owned by: radix
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

It talks about things "similar to the names specified in self.arguments". It's not clear what "similar" means in this context. It should also probably be talking about self.response, not self.arguments, since it is makeResponse.

Change History

Changed 3 years ago by exarkun

Also, the first sentence of the docstring for makeResponse doesn't really make sense: I don't know what a "custom factory response" is.

Changed 3 years ago by radix

  • owner changed from glyph to radix
  • status changed from new to assigned

See #2657 for where the work for this fix is happening.

Changed 3 years ago by radix

  • status changed from assigned to closed
  • resolution set to fixed

(In [20391]) Merge amp-factoring-2657+2667.

Author: radix Reviewer: therve Fixes #2657 Fixes #2667 Fixes #2656 Fixes #2664

It is now possible to use public methods on Command objects to serialize and parse arguments and responses based on that Commandn's arguments and response schemas. It was already possible to serialize responses via the Command in this way; analogs for the other three cases were added. (#2657 & #2667).

Some docstrings in nearby code were alse fixed in this branch. (#2656 & #2664).

Note: See TracTickets for help on using tickets.