Opened 11 years ago

Closed 9 years ago

#2644 enhancement closed duplicate (duplicate)

Errors while writing dropin.cache should show a less horrible error message

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Jean-Paul Calderone Branch:
Author:

Description

I suggest doing something like

log.err("warning: Couldn't write dropin.cache file because %s" % (e,))

instead of log.err()

Change History (9)

comment:1 Changed 11 years ago by Jean-Paul Calderone

Cc: Jean-Paul Calderone added

Surely you mean log.err(None, "...")?

comment:2 Changed 11 years ago by radix

Owner: changed from Glyph to radix
Status: newassigned

lol.

I don't mean that, because that would cause the traceback to still be printed. That's what I'm trying to avoid.

comment:3 Changed 11 years ago by Jean-Paul Calderone

I'm not sure it's an improvement to make a system misconfiguration less visible.

In any case, the message should not start with warning. The rest of the example sentence conveys just as much information without the prefix.

comment:4 Changed 9 years ago by Glyph

I do believe that the most common error - that the dropin.cache file cannot be opened for writing - should be caught and logged as a warning rather than an error. I'll file a separate ticket for that.

comment:5 Changed 9 years ago by Glyph

(by "logged as a warning" I mean "warnings.warn", not log.err("something misleading")).

comment:6 in reply to:  4 ; Changed 9 years ago by radix

Replying to glyph:

I do believe that the most common error - that the dropin.cache file cannot be opened for writing - should be caught and logged as a warning rather than an error. I'll file a separate ticket for that.

Does such a ticket exist yet? I can't find it. But actually, that particular case is all I was referring to when I made this ticket, so I don't think a separate ticket needs to be filed.

comment:7 in reply to:  6 Changed 9 years ago by Glyph

Replying to radix:

Replying to glyph:

I do believe that the most common error - that the dropin.cache file cannot be opened for writing - should be caught and logged as a warning rather than an error.

Does such a ticket exist yet?

I believe #2409 is the ticket in question. Is this a duplicate now?

comment:8 Changed 9 years ago by Jean-Paul Calderone

Resolution: duplicate
Status: assignedclosed

Yes. Thanks for finding that.

comment:9 Changed 7 years ago by <automation>

Owner: radix deleted
Note: See TracTickets for help on using tickets.