Ticket #2589 (closed defect: wontfix )

Opened 3 years ago

Last modified 7 months ago

trial --help should warn of the dangers of --temp-directory

Reported by: jml Assigned to: thijs
Type: defect Priority: high
Milestone: Component: trial
Keywords: documentation Cc: thijs
Branch: branches/trial-temp-2589 Author: thijs
Launchpad Bug:

Description

Nyah, nyah, no bug description for you.

Attachments

Change History

  2008-09-17 03:01:47+00:00 changed by thijs

  • status changed from new to assigned
  • author deleted
  • cc set to thijs
  • launchpad_bug deleted
  • branch deleted
  • owner changed from jml to thijs

What are those dangers? ;)

  2008-09-26 16:23:45+00:00 changed by thijs 

[18:22] thijs: anyone can answer this question? http://twistedmatrix.com/trac/ticket/2589#comment:1
[18:22] thijs: 'Nyah, nyah, no bug description for you.'
[18:22] exarkun: jml is a jerk :(
[18:22] thijs: should be closed ;)
[18:22] exarkun: trial will delete the directory that you pass to --trial-temp
[18:22] exarkun: and everything in it
[18:22] thijs: ok

  2008-09-26 16:27:03+00:00 changed by thijs

  • priority changed from normal to high

  2008-09-26 16:36:08+00:00 changed by thijs

  • branch set to branches/trial-temp-2589
  • author set to thijs

(In [24929]) Branching to 'trial-temp-2589'

  2008-09-28 20:25:32+00:00 changed by thijs

  • keywords set to documentation, review
  • owner deleted
  • status changed from assigned to new

See r24941

follow-up: ↓ 12   2008-10-09 08:25:56+00:00 changed by therve

  • keywords changed from documentation, review to documentation
  • owner set to thijs

It's a bit light I think. We could put that has been put in the man page as well: "WARNING: Do not use this options unless you know what you are doing."

follow-up: ↓ 8   2008-10-12 13:48:12+00:00 changed by exarkun

This should be easy to fix for real, let's not just document the bad behavior. trial should drop a marker file into _trial_temp and refuse to delete and re-create any directory that doesn't have the marker. The docs should still say that trial deletes the directory, but far fewer people will care since it won't delete their home directory anymore.

in reply to: ↑ 7 ; follow-up: ↓ 9   2008-10-21 09:34:15+00:00 changed by thijs

  • status changed from new to assigned

Replying to exarkun:

This should be easy to fix for real, let's not just document the bad behavior. trial should drop a marker file into _trial_temp and refuse to delete and re-create any directory that doesn't have the marker.

I opened a new ticket (#3481) for this issue because that improvement is not a documentation problem.

in reply to: ↑ 8   2009-03-22 19:43:52+00:00 changed by thijs

Replying to thijs:

I opened a new ticket (#3481) for this issue because that improvement is not a documentation problem.

So I suggest adding in this warning until #3481 is fixed.

  2009-04-17 13:02:33+00:00 changed by exarkun

Ok

  2009-05-17 17:26:06+00:00 changed by thijs

(In [26937]) Add warning for trial's temp-directory option, refs #2589

in reply to: ↑ 6   2009-05-17 17:28:19+00:00 changed by thijs

  • keywords changed from documentation to documentation, review
  • owner deleted
  • status changed from assigned to new

Replying to therve:

It's a bit light I think. We could put that has been put in the man page as well: "WARNING: Do not use this options unless you know what you are doing."

Added the warning, up for review. Also replaced some single quotes for the options so it's consistent, and makes it more readable with a syntax highlighter like xcode.

  2009-06-04 21:22:24+00:00 changed by polvi

  • keywords changed from documentation, review to documentation
  • owner set to thijs

As a potential user of this function, I think the temp-directory usage is clear and appropriately scary.

  2009-07-07 23:23:07+00:00 changed by thijs

  • status changed from new to closed
  • resolution set to wontfix

Closing this ticket as wontfix since #2589 landed in r27098, fixing the issue that this ticket warns about.

Note: See TracTickets for help on using tickets.