Ticket #2589 (closed defect: wontfix)

Opened 3 years ago

Last modified 14 months ago

trial --help should warn of the dangers of --temp-directory

Reported by: jml Owned by: thijs
Priority: high Milestone:
Component: trial Keywords: documentation
Cc: thijs Branch: branches/trial-temp-2589
Author: thijs Launchpad Bug:

Description

Nyah, nyah, no bug description for you.

Change History

  Changed 2 years ago by thijs

  • owner changed from jml to thijs
  • cc thijs added
  • status changed from new to assigned

What are those dangers? ;)

  Changed 2 years ago by thijs 

[18:22] thijs: anyone can answer this question? http://twistedmatrix.com/trac/ticket/2589#comment:1
[18:22] thijs: 'Nyah, nyah, no bug description for you.'
[18:22] exarkun: jml is a jerk :(
[18:22] thijs: should be closed ;)
[18:22] exarkun: trial will delete the directory that you pass to --trial-temp
[18:22] exarkun: and everything in it
[18:22] thijs: ok

  Changed 2 years ago by thijs

  • priority changed from normal to high

  Changed 2 years ago by thijs

  • branch set to branches/trial-temp-2589
  • author set to thijs

(In [24929]) Branching to 'trial-temp-2589'

  Changed 2 years ago by thijs

  • owner thijs deleted
  • status changed from assigned to new
  • keywords documentation, review added

See r24941

follow-up: ↓ 12   Changed 23 months ago by therve

  • keywords documentation added; documentation, review removed
  • owner set to thijs

It's a bit light I think. We could put that has been put in the man page as well: "WARNING: Do not use this options unless you know what you are doing."

follow-up: ↓ 8   Changed 23 months ago by exarkun

This should be easy to fix for real, let's not just document the bad behavior. trial should drop a marker file into _trial_temp and refuse to delete and re-create any directory that doesn't have the marker. The docs should still say that trial deletes the directory, but far fewer people will care since it won't delete their home directory anymore.

in reply to: ↑ 7 ; follow-up: ↓ 9   Changed 23 months ago by thijs

  • status changed from new to assigned

Replying to exarkun:

This should be easy to fix for real, let's not just document the bad behavior. trial should drop a marker file into _trial_temp and refuse to delete and re-create any directory that doesn't have the marker.

I opened a new ticket (#3481) for this issue because that improvement is not a documentation problem.

in reply to: ↑ 8   Changed 18 months ago by thijs

Replying to thijs:

I opened a new ticket (#3481) for this issue because that improvement is not a documentation problem.

So I suggest adding in this warning until #3481 is fixed.

  Changed 17 months ago by exarkun

Ok

  Changed 16 months ago by thijs

(In [26937]) Add warning for trial's temp-directory option, refs #2589

in reply to: ↑ 6   Changed 16 months ago by thijs

  • owner thijs deleted
  • status changed from assigned to new
  • keywords documentation, review added; documentation removed

Replying to therve:

It's a bit light I think. We could put that has been put in the man page as well: "WARNING: Do not use this options unless you know what you are doing."

Added the warning, up for review. Also replaced some single quotes for the options so it's consistent, and makes it more readable with a syntax highlighter like xcode.

  Changed 15 months ago by polvi

  • owner set to thijs
  • keywords documentation added; documentation, review removed

As a potential user of this function, I think the temp-directory usage is clear and appropriately scary.

  Changed 14 months ago by thijs

  • status changed from new to closed
  • resolution set to wontfix

Closing this ticket as wontfix since #2589 landed in r27098, fixing the issue that this ticket warns about.

Note: See TracTickets for help on using tickets.