Opened 7 years ago

Closed 6 years ago

#2512 enhancement closed fixed (fixed)

simple typo in twisted/internet/error.py

Reported by: thomasvs Owned by:
Priority: low Milestone:
Component: core Keywords:
Cc: moonfallen Branch:
Author: Launchpad Bug:

Description

This typo has been around a long time.

Attaching patch. I hope this is what was meant to be said.

Attachments (2)

process.patch (451 bytes) - added by thomasvs 7 years ago.
error.diff (518 bytes) - added by exarkun 6 years ago.
change excited to exited, leave has alone

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by thomasvs

comment:1 Changed 7 years ago by moonfallen

Um, as long as you're in there, could you fix the *other* typo in that sentence too? "exited". :-)

comment:2 Changed 7 years ago by moonfallen

  • Cc moonfallen added

comment:3 Changed 7 years ago by thomasvs

Oh, well how am I supposed to know which direction the developers wanted to go with their docstring ? I was just excited to be able to contribute.

I am happy if this gets fixed either way to uphold the excellent quality image of Twisted! Would it be better to do the fixing work on a branch ?

comment:4 Changed 7 years ago by therve

You should probably add a unittest to verify that the word 'excited' is not in the doctring anymore. It's not in the twisted 'family spirit' policy, because it vehicles subversive ideas.

comment:5 Changed 7 years ago by moonfallen

  • Owner changed from glyph to moonfallen
  • Status changed from new to assigned

No unit test or branch is necessary. I just thought it was strange that you fixed one typo and not the other. :-P Technically we're not supposed to review changes we made ourselves, and I'd like to review and commit your change.

Changed 6 years ago by exarkun

change excited to exited, leave has alone

comment:6 Changed 6 years ago by exarkun

  • Keywords review added
  • Owner moonfallen deleted
  • Status changed from assigned to new

has looks correct to me in that context. I fixed excited in the attached patch, though.

comment:7 Changed 6 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Please apply.

comment:8 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [23960]) Apply error.diff, fixing the docstring of ProcessExitedAlready

Author: exarkun
Reviewer: therve
Fixes: #2512

Reformat the docstring of ProcessExitedAlready and fix the spelling of
"exited".

comment:9 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.