simple typo in twisted/internet/error.py

[thomasvs]

This typo has been around a long time.

Attaching patch. I hope this is what was meant to be said.

[moonfallen]

Um, as long as you're in there, could you fix the *other* typo in that sentence too? "exited". :-)

[thomasvs]

Oh, well how am I supposed to know which direction the developers wanted to go with their docstring ? I was just excited to be able to contribute.

I am happy if this gets fixed either way to uphold the excellent quality image of Twisted! Would it be better to do the fixing work on a branch ?

[therve]

You should probably add a unittest to verify that the word 'excited' is not in the doctring anymore. It's not in the twisted 'family spirit' policy, because it vehicles subversive ideas.

[moonfallen]

No unit test or branch is necessary. I just thought it was strange that you fixed one typo and not the other. :-P Technically we're not supposed to review changes we made ourselves, and I'd like to review and commit your change.

[exarkun]

change excited to exited, leave has alone

[exarkun]

has looks correct to me in that context. I fixed excited in the attached patch, though.

[therve]

Please apply.

[exarkun]

(In [23960]) Apply error.diff, fixing the docstring of ProcessExitedAlready

Author: exarkun Reviewer: therve Fixes: #2512

Reformat the docstring of ProcessExitedAlready and fix the spelling of "exited".