Use cProfile for twistd profiling on 2.5

[jack]

patch to add cprofile support (falls back to profile for older pythons)

[zooko]

I just looked at the attached diff and it looks right. What's the next step to push this into trunk?

In a related issue:

 http://docs.python.org/lib/module-hotshot.html

^{-- this says "For common usages it is recommended to use cProfile instead. hotshot is not maintained and might be removed from the standard library in the future."}

So perhaps the logic of using hotshot by default and falling back to profile/cProfile should be reversed to use profile/cProfile by default.

[therve]

The problem is that currently twistd is very hard to test (because of a structure problem), and no feature will be added before we manage to test it.

The ticket with the highest priority on this subject is #2571, but I'm unable to progress on it. Any help here is welcome :).

[therve]

(In [22523]) Branching to 'cprofile-2469'

[therve]

(In [22524]) Add cprofile runner, with tests.

Refs #2469

[exarkun]

twisted.test.test_twistd.AppProfilingTestCase.test_cProfile and twisted.test.test_twistd.AppProfilingTestCase.test_cProfileSaveStats fail on the dumb debian pstats-less configuration. Guess they should check pstats availability and skip if it is not around.

[therve]

Thanks for the check, it looks better.

[dreid]

Great work as always therve, however my gut reaction is that the AppProfiler.profilers dictionary should be keyed on the module name. i.e. profile, hotshot, and cProfile with an uppercase P.

In fact we call self._reportImportError("cProfile", e) when "cprofile" is specified on the command line, so I definitely think this needs to be addressed.

[therve]

(In [22621]) Rename option flag to cProfile.

Refs #2469

[dreid]

Thanks therve, this looks great, merge away.

[therve]

(In [22627]) Merge cprofile-2469

Author: therve Reviewers: dreid, exarkun Fixes #2469

Add cProfile to the list of available profilers for twistd.